Hi David,

Revision
    8042 <http://fisheye.codehaus.org/changelog/mojo/?cs=8042>
Author
    david
Date
    2008-11-10 18:09:27 -0600 (Mon, 10 Nov 2008)


      Log Message

add clean goal

+    /**
+     * Location for generated source files.
+ * + * @parameter expression="${sqlj.generatedSourcesDirectory}"
+     *            
default-value="${project.build.directory}/generated-sources/sqlj-maven-plugin"
+     * @required
+     */
+    private File generatedSourcesLocation;

Some consistency questions:

How about just "${project.build.directory}/generated-sources/sqlj" as the default value? This, i.e. only using the tool name instead of the plugin's artifact id, seems more common from what I have come across so far [0, 1, 2, 3, 4].

Likewise, the parameter is called "*Location" but the corresponding expression "sqlj.*Directory". To prevent unnecesary confusion to users, it might be advisable to unify these such that the expression property is always "sqlj.<paramName>".


Benjamin


[0] http://modello.codehaus.org/modello-maven-plugin/xpp3-writer-mojo.html#outputDirectory [1] http://mojo.codehaus.org/antlr3-maven-plugin/antlr-mojo.html#outputDirectory [2] http://maven.apache.org/plugins/maven-plugin-plugin/helpmojo-mojo.html#outputDirectory
[3] http://mojo.codehaus.org/castor-maven-plugin/generate-mojo.html#dest
[4] http://mojo.codehaus.org/javacc-maven-plugin/javacc-mojo.html#outputDirectory

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email


Reply via email to