nicolas de loof wrote:
After some month of testing and real-world use by my GWT dev team, I'd like
to call for a vote to promote the gwt-maven-plugin from sandbox
0, not using it. The notes:
The POM inherits from an older Mojo parent. Among others, the latest
mojo-parent:18 provides the correct mailing liist info.
The POM's <prerequisites> element is empty which - by the default values
of the model - means Maven 2.0. However, the plugin has dependencies on
plexus-utils:1.4.6 (requires Maven 2.0.6+) and various Maven artifacts
in version 2.0.9.
The site.xml could be trimmed down since most of the stuff is inherited
(see also [0]).
The POM snippets on the site are missing the <version> element for the
plugin, thereby promoting bad practices to the user.
Some POM snippets use tabs for the indentation. In combination with
spaces, this leads to a suboptimal reading experience (e.g. [1]).
Some typos on the FAQ:
- "librairies" should be "libraries"
- "developpers" should be "developers"
And on examples\test.apt
- "usefull" should be "useful"
The parameter project in AbstractGwtMojo should most likely be marked
"@readonly".
AFAIK, the syntax "@parameter
expression="${component....ArchiverManager}" is deprecated. Instead, the
single annoation @component replaces the combo @parameter, @readonly and
@required.
The parameter outputDirectory in CompileMojo should better use
default-value instead of expression for its @parameter annotation. Same
for generateDirectory in AbstractGwtMojo.
Benjamin
[0]
http://mojo.codehaus.org/development/guidelines.html#Plugin_Site_Template
[1] http://mojo.codehaus.org/gwt-maven-plugin/examples/i18n.html
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
