Vote passed with
+4 : Arnaud, David, Kriss & Wayne
and nice notes from Benjamin
2008/11/20 nicolas de loof <[EMAIL PROTECTED]>
> Thanks a lot for your detailled review,
>
>
>>
>> The POM inherits from an older Mojo parent. Among others, the latest
>> mojo-parent:18 provides the correct mailing liist info.
>
>
> I did not notice the parent artifactId change from "mojo" to "mojo-parent".
>
>
>
>> The POM's <prerequisites> element is empty which - by the default values
>> of the model - means Maven 2.0. However, the plugin has dependencies on
>> plexus-utils:1.4.6 (requires Maven 2.0.6+) and various Maven artifacts in
>> version 2.0.9.
>
>
> Right, fixed to 2.0.9, as it was never tested on earlier version, and
> option to override the GWT version used by the plugin also requires 2.0.9
>
>
>
>> The site.xml could be trimmed down since most of the stuff is inherited
>> (see also [0]).
>>
>> The POM snippets on the site are missing the <version> element for the
>> plugin, thereby promoting bad practices to the user.
>
>
> Very good point
>
>
>> Some POM snippets use tabs for the indentation. In combination with
>> spaces, this leads to a suboptimal reading experience (e.g. [1]).
>>
>> Some typos on the FAQ:
>> - "librairies" should be "libraries"
>> - "developpers" should be "developers"
>> And on examples\test.apt
>> - "usefull" should be "useful"
>>
>
> Fixed
>
>
>>
>> The parameter project in AbstractGwtMojo should most likely be marked
>> "@readonly".
>>
>> AFAIK, the syntax "@parameter expression="${component....ArchiverManager}"
>> is deprecated. Instead, the single annoation @component replaces the combo
>> @parameter, @readonly and @required.
>>
>> The parameter outputDirectory in CompileMojo should better use
>> default-value instead of expression for its @parameter annotation. Same for
>> generateDirectory in AbstractGwtMojo.
>>
>
> Fixed
>
> a new SNAPSHOT has been deployed, site is up-to-date
>
