Erik Drolshammer wrote:

I would like to call a vote for a 1.0 release of the appassembler-maven-plugin.

+0, not using it. Notes:

mvn dependency:analyze reports some undeclared dependencies.

The mojo parameters "basedir" and "project" in GenerateDaemonsMojo should likely be @readonly. Besides, the mojo parameter "target" should better use "default-value=" than "expression=".

The examples [0] and [1] show your personal directory path ("<target>/home/erik/dev/oss/..."). I assume there are some ${...} expressions inside the APT source file that are not meant to be filtered.

The POM snippet on [2] refers to the expression "${pom.groupId}". The "pom." prefix is deprecated so should better be replaced with the preferred "project." prefix to not confuse users.

The license page is broken [3].


Benjamin


[0] http://mojo.codehaus.org/appassembler/appassembler-maven-plugin/example-jsw-linux.html [1] http://mojo.codehaus.org/appassembler/appassembler-maven-plugin/usage_bin.html [2] http://mojo.codehaus.org/appassembler/appassembler-maven-plugin/usage_jsw.html [3] http://mojo.codehaus.org/appassembler/appassembler-maven-plugin/license.html

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email


Reply via email to