Benjamin Bentmann wrote:
Erik Drolshammer wrote:
I would like to call a vote for a 1.0 release of the
appassembler-maven-plugin.
+0, not using it. Notes:
The mojo parameters "basedir" and "project" in GenerateDaemonsMojo
should likely be @readonly. Besides, the mojo parameter "target" should
better use "default-value=" than "expression=".
I don't know these properties well enough to conclude one way or the
other. Can someone (TM) help me with these?
mvn dependency:analyze reports some undeclared dependencies.
The examples [0] and [1] show your personal directory path
("<target>/home/erik/dev/oss/..."). I assume there are some ${...}
expressions inside the APT source file that are not meant to be filtered.
The POM snippet on [2] refers to the expression "${pom.groupId}". The
"pom." prefix is deprecated so should better be replaced with the
preferred "project." prefix to not confuse users.
The license page is broken [3].
Thanks for pointing these out and help me fix them, Benjamin.
A new snapshot and a new site have been deployed.
--
Best regards
Erik Drolshammer
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
