[ 
http://jira.codehaus.org/browse/MOJO-1303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=167562#action_167562
 ] 

Thomas Marti commented on MOJO-1303:
------------------------------------

Hi Dirk

There is a major flaw in the logic of your patch. You assume that child 
projects are only ever built in the context of their parents. That goes against 
a very fundamental Maven rule that you have to able to build sub-projects on 
their own. So in your example if you go to project 'bar1' and build from there 
your patch won't work anymore.

We had a similar problem in our project setup. The solution we used was to put 
all properties files in a separate 'settings' project. I then pimped the 
properties-maven-plugin a bit, so you can also specify properties files inside 
dependencies. The code is not polished for public release yet, but if you're 
interested you can drop me a mail and I can send you the files.

> read-project-properties in parent pom does not make the properties accessible 
> for child modules
> -----------------------------------------------------------------------------------------------
>
>                 Key: MOJO-1303
>                 URL: http://jira.codehaus.org/browse/MOJO-1303
>             Project: Mojo
>          Issue Type: Bug
>          Components: properties
>            Reporter: Dirk Olmes
>            Priority: Critical
>         Attachments: projects-with-plugin.zip, projects-with-property.zip, 
> ReadPropertiesMojo.patch
>
>
> Declaring a property in a parent pom (reactor build) makes it available for 
> all child modules. Reading in properties using the read-project-properties 
> goal fails to make the properties read from the file available in child 
> modules.
> I have attached two sets of poms demonstrating the bug: if you build the 
> contents of projects-with-property.zip the final name of the baz1 jar will 
> include the value of the declared property. If you build the contents of 
> projects-with-plugin.zip the final name of the bar1 jar will not include the 
> value of the read property.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to