Could you give me a pointer to where similar code exists in maven? I assumed it had to for the ApacheVersionNumber, I spent about 15 minutes looking but could not find anything like what I needed for this patch.
Also, would you be opposed to the whole clirr:check goal being turned in to an enforcer rule? Thanks, Rex On Sun, Jul 11, 2010 at 9:32 AM, Robert Scholte <[email protected]>wrote: > I think I have to agree with Evgeny. > This type of functionality belongs to the versions-maven-plugin or > maven-enforcer-plugin, if it's not already there. > Also, the sources of ApacheVersionNumber looks like duplicate code, similar > code is already available in the Maven distribution. > > - Robert > > ------------------------------ > Date: Sun, 11 Jul 2010 03:11:10 -0700 > From: [email protected] > To: [email protected] > Subject: Re: [mojo-dev] Hi all! Just tossed three patches at the clirr mojo > > > May I ask why? > > It seemed like a very natural fit to me. A tool like clirr seemed as it > were built to help enforce version standards. > Why not have it be explicit? > > Rex > > On Sun, Jul 11, 2010 at 3:03 AM, Evgeny Mandrikov <[email protected]>wrote: > > Hi Rex, > > First of all - thanks for your contribution. But I'm not sure about > MCLIRR-33 - I think that clirr plugin should not be used for such > tasks. > > On Sun, Jul 11, 2010 at 8:14 AM, Rex Hoffman <[email protected]> wrote: > > First up, Thanks all for great maven plugins!!! > > So just lobbed 3 jiras against the clirr mojo, all with patches of > course. > > http://jira.codehaus.org/browse/MCLIRR-31 > > http://jira.codehaus.org/browse/MCLIRR-32 > > http://jira.codehaus.org/browse/MCLIRR-33 > > Site documentation fully updated. > > 33's patch unfortunately contains the contents of 32's as well. > > Did my best to minimize any potential side-effects. Gave the code it's > > first test (not a very impressive one). > > I'd also like to write a plugin that takes the version number convergence > > checks that are done in by the dependency analysis report and enforce > them > > at build time. > > If you'd be willing to host it here, I'd be appreciative. > > Rex Hoffman > > > > -- > Best regards, > Evgeny Mandrikov aka Godin <http://godin.net.ru> > http://twitter.com/_godin_ > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > > > > ------------------------------ > New Windows 7: Simplify what you do everyday. Find the right PC for > you.<http://windows.microsoft.com/shop> >
