Mark,
right now I see a bit too much issues to give it a +1. here are a few of my remarks, purely based on code and sitedocs - check http://mojo.codehaus.org/apt-maven-plugin/checkstyle.html : 300+ errors is really too much. With the right IDE-settings they can be fixed in seconds. Read http://maven.apache.org/developers/conventions/code.html for the right templates. - Both ProcessMojo and TestProcessMojo have includes/excludes parameters and related getter-method. I can't see any reason why not to pull them up to AbstractAptMojo - Expressions and default-values are often mixed up. - Both parameters of EclipseMojo should use default-value instead of expression - For ProcessMojo: compileSourceRoots, resources, classpathElements - For TestProcessMojo: testCompileSourceRoots, testResources, testClasspathElements - FAQ has a reference to http://jira.codehaus.org/browse/MCOMPILER-75 . This issue is closed as 'fixed', which could suggest that this might be one of the final heartbeats of this plugin. What's your idea on this one? - mvn dependency:analyze shows me the following: [WARNING] Used undeclared dependencies found: [WARNING] org.apache.maven:maven-model:jar:2.0.2:compile [WARNING] org.apache.maven:maven-artifact:jar:2.0.2:compile [WARNING] org.codehaus.plexus:plexus-container-default:jar:1.0-alpha-9:compile - Maven prerequisite value doesn't match the version of the used maven artifacts. I'd suggest to add <mavenVersion>2.0.2</mavenVersion> as property (or 2.0.6) and use this property for both the dependencies and the prerequisite. btw, it seems like you managed to bypass MSITE-459. It's a pretty deep transitive dependency which causes the trouble, but it looks like it's solved in the core (still SNAPSHOT). It can take a while before this solved in the m-site-plugin as well, so I'd suggest you add this to the mojo-parent as well. - Robert > Date: Thu, 16 Sep 2010 17:13:43 +0100 > From: [email protected] > To: [email protected] > Subject: [mojo-dev] [VOTE] Release Maven Apt Plugin version 1.0-alpha-4 > > Hi, > > We solved 3 issues: > http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11062&version=16158 > > There are still a couple of issues left in JIRA: > http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+MOJO+AND+component+%3D+apt+AND+status+%3D+Open+ORDER+BY+priority+DESC&mode=hide > > Staging repo: > https://nexus.codehaus.org/content/repositories/orgcodehausmojo-024/ > > Site: > http://mojo.codehaus.org/apt-maven-plugin/ > > Vote open for 72 hours. > > [ ] +1 > [ ] +0 > [ ] -1 > > Mark > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > >
