[
http://jira.codehaus.org/browse/MWEBSTART-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=240229#action_240229
]
Karl M. Davis commented on MWEBSTART-148:
-----------------------------------------
Benjamin: what is the correct way to do this in Maven 2.x? I've tried taking a
look at the assembly plugin for pointers but it's a rather complex beast
compared to this plugin. Do you know of another plugin mojo doing something
similar correctly?
I've got a project that this bug is blocking right now so I may need to take a
stab at patching it this week. At least, I think it's this bug: when I build my
project by itself, it includes the correct JARs but if built as part of a
multi-mnodule build, all kinds of extra crap gets included.
P.S.: I'm taking a look through the fix to a similar issue in the shades
plugin: http://svn.apache.org/viewvc?view=revision&revision=904309. Would the
same sort of fix apply here?
> Fix dependency resolution/handling
> ----------------------------------
>
> Key: MWEBSTART-148
> URL: http://jira.codehaus.org/browse/MWEBSTART-148
> Project: Maven 2.x Webstart Plugin
> Issue Type: Bug
> Components: jnlps
> Affects Versions: 1.0-alpha-2
> Reporter: Benjamin Bentmann
>
> From the plugin's source:
> {code:java}
> * @requiresDependencyResolution runtime
> */
> public class JnlpMojo
> extends AbstractJnlpMojo
> {
> /**
> * Get the executed project from the forked lifecycle.
> *
> * @parameter expression="${executedProject}"
> * @required
> * @readonly
> */
> private MavenProject executedProject;
> {code}
> and later on in {{processDependencies()}} the equivalent of
> {{executedProject.getArtifacts()}} is invoked.
> This design is flawed. The annotation {...@requiresdependencyresolution
> runtime}} applies to the current project only, not the forked one. So when
> {{executedProject.getArtifacts()}} is called, there is no guarantee that the
> plugin actually grabs the runtime dependencies. Instead (in Maven 2.x), it
> grabs the dependencies that have been resolved for the last plugin that
> participated in the forked {{executedProject}} (see also MNG-3297).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
