[
http://jira.codehaus.org/browse/MWEBSTART-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=240838#action_240838
]
Karl M. Davis commented on MWEBSTART-148:
-----------------------------------------
I've attached a patch to improve the artifact resolution when excludeTransitive
== false, per Benjamin's suggestions.
This does fix the problem I was encountering, though there may still be other
related bugs I didn't fix. I'm afraid I don't understand enough about Bejamin's
description to be sure on that-- especially as relates to forked project
execution. Specifically, I'm not sure whether something needs to be fixed when
excludeTransitive == true.
> Fix dependency resolution/handling
> ----------------------------------
>
> Key: MWEBSTART-148
> URL: http://jira.codehaus.org/browse/MWEBSTART-148
> Project: Maven 2.x Webstart Plugin
> Issue Type: Bug
> Components: jnlps
> Affects Versions: 1.0-alpha-2
> Reporter: Benjamin Bentmann
> Attachments:
> 2010-10-24-1730-fix-to-webstart-maven-plugin-for-MWEBSTART-148.patch
>
>
> From the plugin's source:
> {code:java}
> * @requiresDependencyResolution runtime
> */
> public class JnlpMojo
> extends AbstractJnlpMojo
> {
> /**
> * Get the executed project from the forked lifecycle.
> *
> * @parameter expression="${executedProject}"
> * @required
> * @readonly
> */
> private MavenProject executedProject;
> {code}
> and later on in {{processDependencies()}} the equivalent of
> {{executedProject.getArtifacts()}} is invoked.
> This design is flawed. The annotation {...@requiresdependencyresolution
> runtime}} applies to the current project only, not the forked one. So when
> {{executedProject.getArtifacts()}} is called, there is no guarantee that the
> plugin actually grabs the runtime dependencies. Instead (in Maven 2.x), it
> grabs the dependencies that have been resolved for the last plugin that
> participated in the forked {{executedProject}} (see also MNG-3297).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
