[
http://jira.codehaus.org/browse/MNBMODULE-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241957#action_241957
]
Jesse Glick commented on MNBMODULE-115:
---------------------------------------
"Minor" priority until I hear of some concrete problem caused by missing href
(other than apparent noncompliance with the spec); NB has been generating
Platform *.jnlp files without this attribute for years without any reported
issue.
"extend the same options to maven users (as is for ant)" - the difference is
not between Ant- and Maven-based projects as you say. The JNLP files created by
the IDE which include hrefs are those of Java SE projects, not NBM projects.
The Ant-based build harness for NBM applications does not produce
(self-referring) hrefs. Since this remains true in the 6.9.1 harness used by
development versions of the plugin, it is not in fact possible for the plugin
to do otherwise unless and until a version of NB in which this is changed is
released: while the plugin can add self-hrefs to master.jnlp and modules.jnlp
(as branding.jnlp is now called), they will still be missing in individual
module *.jnlp files created by {{MakeJNLP}}.
"even the generated jws for ant is buggy" - I guess you are again referring to
the JNLP support for Java SE projects. This is not the place to mention it.
File a bug on netbeans.org.
"the trunk is broken" - I don't know what you're referring to; this is not the
place to discuss it. "There's an issue with netbeans.jnlp.fixPolicy" - perhaps
you are referring to MNBMODULE-103, already fixed in trunk.
"hard-code the location at development time" - as of MNBMODULE-104 and
MNBMODULE-114 this should not be a problem: the temporary *.jnlp include the
local path for immediate testing with {{javaws .../yourapp.jnlp}}, whereas the
*.war output uses {{$codebase}} correctly.
"building the jnlp/xml dynamically" - not really sure what this is referring
to, but sounds like a topic for a separate issue.
The attached patch is full of junk unrelated to the stated bug, so I am
ignoring it for now. Anyway a fix to add self-hrefs should be trivial, once a
harness version that does so for module JNLPs is available.
> Missing href attribute in maven generated jnlps
> -----------------------------------------------
>
> Key: MNBMODULE-115
> URL: http://jira.codehaus.org/browse/MNBMODULE-115
> Project: Maven NetBeans Module Plugin
> Issue Type: Bug
> Affects Versions: 3.4
> Reporter: Gabriele Kahlout
> Assignee: Jesse Glick
> Priority: Minor
> Attachments: hrefcomply.diff
>
>
> Creating an jws ant project (even in nb 7) with a codebase (one is given the
> option to exclude the codebase choosing to be 1.6.0_18+ only compatible)
> generates a launch.jnlp file with the href attribute as required by the jnlp
> specification.
> Maven created projects on the other hand include codebase but not the href
> and thus don't comply to the 1.6+ standard they claim in the same jnlp, but
> only to the 1.6.18+ standard, which then doesn't require the codebase
> attribute, which makes the difference of not needing to hard-code the
> location at development time (since the .jnlp is executed from the dir other
> referenced files are).
> Hence It's preferred to correct the version issue, and extend the same
> options to maven users (as is for ant).
> I propose a patch which detects whether the codebase is specified and if so
> includes it along with the href. In case it's not specified it will not
> include the href and will set the java version to 1.6.0_18+.
> This change is best accompanied with building the jnlp/xml dynamically
> (instead of having two file versions for each file, on disk and copy them).
> Should be even faster (in memory). It should also be more type-safe since the
> only place there are unsafe strings used to retrieve values is the pom.
> BTW: even the generated jws for ant is buggy. The j2se remeains set to 1.5+
> although without codebase requires 1.6.0_18+. It probably works for most
> developers when they test it, because they are likely to have 1.6.0_18+
> anyway.
> finally I've attached the diff to the trunk. However the trunk is broken!
> Try it before applying this patch. There's an issue with
> netbeans.jnlp.fixPolicy (both on mac and windows)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
