[
http://jira.codehaus.org/browse/MNBMODULE-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241991#action_241991
]
Jesse Glick commented on MNBMODULE-115:
---------------------------------------
It is not fully clear to me from that thread how to reproduce the problem, but
it looks like the self-href is only necessary on the master JNLP, so that a
copy made on the desktop can refer back to the original for updates (after
being resolved relative to the codebase). If true, patch should be trivial:
{noformat}
--- src/main/resources/master.jnlp (revision 13021)
+++ src/main/resources/master.jnlp (working copy)
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE jnlp PUBLIC "-//Sun Microsystems, Inc//DTD JNLP Descriptor 6.0//EN"
"http://java.sun.com/dtd/JNLP-6.0.dtd";>
-<jnlp spec="1.0+" codebase="${jnlp.codebase}">
+<jnlp spec="1.0+" codebase="${jnlp.codebase}" href="${branding.token}.jnlp">
<information>
<title>${app.title}</title>
<vendor>${app.vendor}</vendor>
{noformat}
(Silly that javaws fails to think of using the original filename, but I recall
that codebase was needed for some reason involving the inflexibility of browser
download helper applications.)
> Missing href attribute in maven generated jnlps
> -----------------------------------------------
>
> Key: MNBMODULE-115
> URL: http://jira.codehaus.org/browse/MNBMODULE-115
> Project: Maven NetBeans Module Plugin
> Issue Type: Bug
> Affects Versions: 3.4
> Reporter: Gabriele Kahlout
> Assignee: Jesse Glick
> Priority: Minor
> Attachments: hrefcomply.diff
>
>
> Creating an jws ant project (even in nb 7) with a codebase (one is given the
> option to exclude the codebase choosing to be 1.6.0_18+ only compatible)
> generates a launch.jnlp file with the href attribute as required by the jnlp
> specification.
> Maven created projects on the other hand include codebase but not the href
> and thus don't comply to the 1.6+ standard they claim in the same jnlp, but
> only to the 1.6.18+ standard, which then doesn't require the codebase
> attribute, which makes the difference of not needing to hard-code the
> location at development time (since the .jnlp is executed from the dir other
> referenced files are).
> Hence It's preferred to correct the version issue, and extend the same
> options to maven users (as is for ant).
> I propose a patch which detects whether the codebase is specified and if so
> includes it along with the href. In case it's not specified it will not
> include the href and will set the java version to 1.6.0_18+.
> This change is best accompanied with building the jnlp/xml dynamically
> (instead of having two file versions for each file, on disk and copy them).
> Should be even faster (in memory). It should also be more type-safe since the
> only place there are unsafe strings used to retrieve values is the pom.
> BTW: even the generated jws for ant is buggy. The j2se remeains set to 1.5+
> although without codebase requires 1.6.0_18+. It probably works for most
> developers when they test it, because they are likely to have 1.6.0_18+
> anyway.
> finally I've attached the diff to the trunk. However the trunk is broken!
> Try it before applying this patch. There's an issue with
> netbeans.jnlp.fixPolicy (both on mac and windows)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
