[ 
http://jira.codehaus.org/browse/MASPECTJ-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=261914#action_261914
 ] 

nodje commented on MASPECTJ-94:
-------------------------------

I've been investigating a bit the problem, and it seems the only things the 
plugin does with the specified <aspectLibraries> is to add them to the compile 
command line following the -aspectpath argument.
That leave no simple direct option to be able to combine that with the 
specified <excludes> which work only on the included source path level.

First of all, is it a good idea to have <excludes> working on both sourcePath 
and aspectLibraries?
I'm not able to answer that question. ASAIK, -classpath seems to mix up classes 
to weave and aspect to apply.
So why not apply exclusions to -aspectpath as well?

If it makes sense, I can't find a good way to exclude aspect from -aspectpath 
in the native ajc doc anyway.
It would then be necessary to treat the jar as classes and include them as 
classpath.

Writing this made me realize that since sources to weave and aspect sources are 
mixed, I could include the aspect jars as <weaveDependency>, and it indeed 
works! But it's not filtered by the maven exclusion either... to bad.



> <excludes> could also filter aspects included in <aspectLibrary>
> ----------------------------------------------------------------
>
>                 Key: MASPECTJ-94
>                 URL: http://jira.codehaus.org/browse/MASPECTJ-94
>             Project: Mojo AspectJ Plugin
>          Issue Type: Improvement
>    Affects Versions: 1.3.1
>         Environment: all
>            Reporter: nodje
>         Attachments: AcpectLibraryExclusionsAntStyle.zip
>
>
> I was trying to exclude an aspect contained in spring-aspects library, that I 
> was specifying as <aspectLibrary> in the config, when I realized it couldn't 
> be filtered.
> I've created a test that fails when aspectLibrary aspect are woven despite 
> their exclusion. It is to be added to the src/it tests.
> It's not very clean as it's based on an external aspect library 
> (spring-aspects), but it shows what is expected clearly I believe.
> Let me know if I'm being unclear.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to