[
http://jira.codehaus.org/browse/MASPECTJ-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=262047#action_262047
]
nodje commented on MASPECTJ-94:
-------------------------------
maven-dependency-plugin seems good to me.
Since all included JARS, be it weaveDependency or aspectLibrary, can contain
aspect, I can't see any reason to make a difference between these two.
There should be a level of abstraction between the plugin and AJC, providing
something in the line of ~ <includeJarDependency> that should be unpacked and
included as source, so that we can a single consistent behavior across all
aspect to apply.
I can't help but finding it very odd that ajc provides a -inpath and a
-aspectpath and that both can contain aspect to be applied on source. There
must be a good reason. I've open the question on Stackoverflow.
Anyway, even if it makes sense to keep weaveDependency or aspectLibrary, they
both should be unpacked and included as source folder.
> <excludes> could also filter aspects included in <aspectLibrary>
> ----------------------------------------------------------------
>
> Key: MASPECTJ-94
> URL: http://jira.codehaus.org/browse/MASPECTJ-94
> Project: Mojo AspectJ Plugin
> Issue Type: Improvement
> Affects Versions: 1.3.1
> Environment: all
> Reporter: nodje
> Attachments: AcpectLibraryExclusionsAntStyle.zip
>
>
> I was trying to exclude an aspect contained in spring-aspects library, that I
> was specifying as <aspectLibrary> in the config, when I realized it couldn't
> be filtered.
> I've created a test that fails when aspectLibrary aspect are woven despite
> their exclusion. It is to be added to the src/it tests.
> It's not very clean as it's based on an external aspect library
> (spring-aspects), but it shows what is expected clearly I believe.
> Let me know if I'm being unclear.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
