[ 
https://jira.codehaus.org/browse/MOJO-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=278245#comment-278245
 ] 

Robert Scholte commented on MOJO-1732:
--------------------------------------

I've done another quick review and it's looking pretty good.
One thing I noticed is the usage of only {{String}} as parameter, whereas 
Plexus is capable in converting values. So for instance the {{lessJs}} field 
could be a {{File}}.
Maybe a nice feature: 
{code}
if ( "war".equals( mavenProject.packaging ))
{
  //also look for sources in the webDirectory as defined in in the 
maven-war-plugin
}
{code}

I'd prefer to wait untill the LessEngine is available at Maven Central, so we 
have a clean start.

Off topic:
AFAIK this can be the first css-maven-plugin here.
There's another css-plugin which should be written: cssimports-maven-plugin, 
which can resolve {{@import()}}-statements. I wasn't aware of it, but these are 
really huge response/performance-killers. I have some other prio things on my 
list, but ít should be too hard for me to develop this too.



> Create project for lesscss Mojo
> -------------------------------
>
>                 Key: MOJO-1732
>                 URL: https://jira.codehaus.org/browse/MOJO-1732
>             Project: Mojo
>          Issue Type: New Feature
>          Components: _Plugin Submission
>            Reporter: Marcel Overdijk
>            Assignee: Christopher Hunt
>         Attachments: lesscss-maven-plugin.zip, lesscss-maven-plugin.zip, 
> lesscss-maven-plugin.zip, lesscss-maven-plugin.zip
>
>
> As discussed on the mailing list I'm working on a new Maven plugin for 
> lesscss (www.lesscss.org).
> Less is the dynamic stylesheet language and the plugin will provide 
> compilation of .less files to ordinary .css files, mainly during the compile 
> or package (war) phase.
> Could you please create this project in the sandbox so I can work on this?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to