[ 
https://jira.codehaus.org/browse/MOJO-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=277739#comment-277739
 ] 

Robert Scholte commented on MOJO-1732:
--------------------------------------

Just a few remarks:
* Personally I don't like it when a mojo has getters and setters just for 
testing purpose. Right now Plexus will use these methods to set the value, 
where the \@{{parameter}} fields are just enough. By using the 
{{AbstractMojoTestCase}} from the maven-plugin-testing-harness you have the 
following methods to do the same thing: {{setVariableValueToObject(Object, 
String, Object)}}  and {{getVariableValueFromObject(Object, String)}}
* Try to add some integration tests to have some working real world examples. 
Almost every released mojo-project has a {{src/it}} which you could use as 
example.
* Remove the FAQ-page: an empty FAQ-page is worse than no FAQ-page. (or think 
of one entry ;) )
* When plugins evolve, users often want more control over resources, which 
would often mean: use {{Resources}} instead of include/exclude. This way you 
can also offer filtering. I don't know if you should do so, but at least think 
about it.

> Create project for lesscss Mojo
> -------------------------------
>
>                 Key: MOJO-1732
>                 URL: https://jira.codehaus.org/browse/MOJO-1732
>             Project: Mojo
>          Issue Type: New Feature
>          Components: _Plugin Submission
>            Reporter: Marcel Overdijk
>         Attachments: lesscss-maven-plugin.zip, lesscss-maven-plugin.zip
>
>
> As discussed on the mailing list I'm working on a new Maven plugin for 
> lesscss (www.lesscss.org).
> Less is the dynamic stylesheet language and the plugin will provide 
> compilation of .less files to ordinary .css files, mainly during the compile 
> or package (war) phase.
> Could you please create this project in the sandbox so I can work on this?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Reply via email to