I would prefer solution 1 and just document this behaviour (and set the Bamboo job to Maven 3). Otherwise you will have this switch in code, you should introduce two ITs, one with a failure status on Maven 3 and one with a skipped message on Maven 2.
Honestly, new feature, new Maven should be no problem. Regards Mirko -- Sent from my mobile On Mar 16, 2013 10:42 PM, "Baptiste MATHUS" <[email protected]> wrote: > In the circular IT, there's a circular dependency (now that's some news!). > > But M2 just ignores it silently, not M3. I think we hit > http://jira.codehaus.org/browse/MNG-1944 > > So, here we have an choice: either we > 1) explicitly state (and check during execution?) that this rule can only > be useful with M3 or > 2) we simply remove it. > > I'd be for solution 1. I feel it's a valuable addition and as it works for > the latest and greatest Maven, this makes sense to keep it. > > WDYT? > > Cheers > > > 2013/3/15 Baptiste MATHUS <[email protected]> > >> No problem, and true for the IT. >> I've copied the demo from the website and forgot to update that part. >> I can re-roll a release. Now that the hard part of configuring the >> machine, releasing is easy ;-). >> I'll re-roll now. >> >> Current vote canceled. >> >> >> 2013/3/15 Mirko Friedenhagen <[email protected]> >> >>> Hello Baptiste, >>> >>> I updated the documentation and the corresponding tests for the >>> required*Roles rules and think maybe we should roll a new version for >>> this. And at least one of the integration tests will break (fixed in >>> https://fisheye.codehaus.org/changelog/mojo/?cs=18017), when you did >>> not have a previous SNAPSHOT version built on your system :-) >>> >>> +0.5 >>> >>> Regards Mirko >>> >>> On Thu, Mar 14, 2013 at 11:21 PM, Fred Cooke <[email protected]> >>> wrote: >>> > +1 sounds interesting! >>> > >>> > >>> > On Thu, Mar 14, 2013 at 10:37 PM, Baptiste Mathus <[email protected]> >>> wrote: >>> >> >>> >> Hi, >>> >> >>> >> I'd like to release version 1.0-alpha-4 of the extra-enforcer-rules >>> >> project. >>> >> >>> >> Extra Enforcer Rules is a project containing extra rules for Apache >>> >> Maven's Enforcer Plugin. >>> >> >>> >> We solved 7 issues: >>> >> >>> >> >>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11062&version=18450 >>> >> >>> >> There are still a couple of issues left in JIRA: >>> >> >>> >> >>> https://jira.codehaus.org/issues/?jql=project%20%3D%20MOJO%20AND%20component%20%3D%20extra-enforcer-rules%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC >>> >> >>> >> Staging Repositories: >>> >> General: https://nexus.codehaus.org/content/groups/staging/ >>> >> Exclusive: >>> >> https://nexus.codehaus.org/content/repositories/orgcodehausmojo-031/ >>> >> >>> >> (Staging) Site: >>> >> http://mojo.codehaus.org/extra-enforcer-rules/ >>> >> >>> >> SCM Tag: >>> >> https://svn.codehaus.org/mojo/tags/extra-enforcer-rules-1.0-alpha-4/ >>> >> >>> >> Note that this version includes two new rules: >>> >> * enforcerBytecodeVersion : rule to check that bytecode of >>> dependencies is >>> >> not higher than expected >>> >> * banCircularDependencies : rule to prevent having circular >>> dependencies >>> >> >>> >> [ ] +1 >>> >> [ ] +0 >>> >> [ ] -1 >>> >> >>> >> The vote is open for 72 hours and will succeed by lazy consensus. >>> >> >>> >> Cheers >>> >> >>> >> -- >>> >> Baptiste >>> > >>> > >>> >>> --------------------------------------------------------------------- >>> To unsubscribe from this list, please visit: >>> >>> http://xircles.codehaus.org/manage_email >>> >>> >>> >> >> >> -- >> Baptiste <Batmat> MATHUS - http://batmat.net >> Sauvez un arbre, >> Mangez un castor ! >> > > > > -- > Baptiste <Batmat> MATHUS - http://batmat.net > Sauvez un arbre, > Mangez un castor ! >
