Robert, in my day job I do code reviews a lot and could imagine a diff-link could be a nice thing to have, it is a pity fisheye does not have a functionality like gitweb, see https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=commitdiff;h=surefire-2.14.1;hp=surefire-2.14 for an example. Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ https://bitbucket.org/mfriedenhagen/
On Fri, Jul 5, 2013 at 9:51 PM, Robert Scholte <[email protected]> wrote: > Hi, > > Of course I'm aware of the discussion, but I'm wondering how one test a > release. > If you test it with the staging-profile activated, you'll pull it from the > staging repo. That's the one which will finally end up in Maven Central. > If I want to build it from tag, I'll always do a *clean checkout* by tag. > During a vote the tag won't change (unless there's a very crappy release > manager). You test if it could be built on your system. There are only a > few reasons I can think of why this is required: For companies which don't > allow to pull artifacts from an external repository and must build every > dependency (I'd be sorry for those developers...) or if all backups are > crashed, which probably means that the Earth was hit by an asteroid. Not > sure if the priority of that last human being on earth (if any) is to > restore Maven Central. > Since we allow to reuse the version during staging, I'd prefer to include > that revision in the manifest file. This way if someone has an issue we > can't reproduce we could verify with the revision if he (or we) depends on > the right artifact. > I'm very interested if anyone has ever had an issue because he checked out > the wrong tag and which wouldn't had happened if he or she knew the > revision. > > I'd prefer to do the KEYS check as part of the release, which should be > possible if I'm correct but hasn't been implemented yet. > > Robert > > > > On Fri, 05 Jul 2013 21:15:13 +0200, Mirko Friedenhagen > <[email protected]> wrote: > >> Hello, >> >> on the maven-dev list there are some discussions about the templates for >> votes, they should include a SCM link to the tag including the >> revision/hash and a link to the KEYS file. >> >> While I do not want to complicate the process here with missing license >> headers etc., at least a link to the tag (or even maybe a CLI to produce a >> patch against the latest release) would be quite handy IMO to do a quick >> code review. >> >> While this means a small burden for the release manager, voters will have >> an easier way to do a review IMO. >> >> What do you think? >> >> Regards Mirko > > > --------------------------------------------------------------------- > To unsubscribe from this list, please visit: > > http://xircles.codehaus.org/manage_email > > --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
