[mojo-dev] [RESULT] Re: [mojo-dev] Re: [VOTE] Release MCOBERTURA version 2.6

[Steven Christou]

The vote is in:

[0] +1
[0] +0
[1] -1
Since the snapshot did not pass, I will be dropping the snapshot and 
fixing the cobertura code to address these issues.

Thanks,
Steve.

On 07/09/2013 02:07 PM, Robert Scholte wrote:
Hi,

-1

I did a testrun on http://svn.codehaus.org/qdox/trunk/qdox/

Although this is probably more of an issue of Cobertura rather than 
the plugin, I see some issues: see log-part.
* second line is [INFO] Cobertura null - GNU GPL License (NO WARRANTY)
  What's the null standing for?
* I get a ParseException. The corresponding *generated* code looks 
like this:

      yyn = yysindex[yystate];  //get amount to shift by (shift index)
      if ((yyn != 0) && (yyn += yychar) >= 0 &&
          yyn <= YYTABLESIZE && yycheck[yyn] == yychar)
        {

  It's an unusual but valid construction.

* You might want to have a look at the performance. It looks like the 
new Cobertura is much slower:
mvn org.codehaus.mojo:cobertura-maven-plugin:2.6:cobertura > Total 
time: 5:50.619s
mvn org.codehaus.mojo:cobertura-maven-plugin:2.5.1:cobertura > Total 
time: 3:30.061s

* The report is showing branch-coverage > 100%. This must be wrong. 
The size of the green bar seems correct, it runs out of the 100%-box.

If you need help wi the plugin, let me know.

Robert


[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ qdox ---
[INFO] Cobertura null - GNU GPL License (NO WARRANTY) - See COPYRIGHT 
file
[cobertura] WARN  [main] 
net.sourceforge.cobertura.reporting.ComplexityCalculato
r - JavaNCSS got an error while parsing the java file 
E:\java-workspace\codehaus
-qdox\qdox\target\generated-sources\parser\com\thoughtworks\qdox\parser\impl\Def 

aultJavaCommentParser.java
ParseException in STDIN
Last useful checkpoint: 
"com.thoughtworks.qdox.parser.impl.DefaultJavaCommentPar
ser.yyparse()"
Encountered " "+=" "+= "" at line 395, column 30.
Was expecting one of:
    "instanceof" ...
    ")" ...
    "=" ...
    ">" ...
    "<" ...
    "?" ...
    "==" ...
    "<=" ...
    ">=" ...
    "!=" ...
    "||" ...
    "&&" ...
    "++" ...
    "--" ...
    "+" ...
    "-" ...
    "*" ...
    "/" ...
    "&" ...
    "|" ...
    "^" ...
    "%" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    "<" ...
    "<" ...
    ")" ...
    "<" ...


[cobertura] WARN  [main] 
net.sourceforge.cobertura.reporting.ComplexityCalculato
r - JavaNCSS got an error while parsing the java file 
E:\java-workspace\codehaus
-qdox\qdox\target\generated-sources\parser\com\thoughtworks\qdox\parser\impl\Par 

ser.java
ParseException in STDIN
Last useful checkpoint: 
"com.thoughtworks.qdox.parser.impl.Parser.yyparse()"
Encountered " "+=" "+= "" at line 1687, column 30.
Was expecting one of:
    "instanceof" ...
    ")" ...
    "=" ...
    ">" ...
    "<" ...
    "?" ...
    "==" ...
    "<=" ...
    ">=" ...
    "!=" ...
    "||" ...
    "&&" ...
    "++" ...
    "--" ...
    "+" ...
    "-" ...
    "*" ...
    "/" ...
    "&" ...
    "|" ...
    "^" ...
    "%" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    "<" ...
    "<" ...
    ")" ...
    "<" ...


Report time: 9883ms

[ERROR] 9-jul-2013 19:57:31 
net.sourceforge.cobertura.coveragedata.CoverageDataF
ileHandler loadCoverageData
INFO: Cobertura: Loaded information on 197 classes.
net.sourceforge.cobertura.javancss.parser.ParseException: Encountered 
" "+=" "+=
 "" at line 395, column 30.
Was expecting one of:
    "instanceof" ...
    ")" ...
    "=" ...
    ">" ...
    "<" ...
    "?" ...
    "==" ...
    "<=" ...
    ">=" ...
    "!=" ...
    "||" ...
    "&&" ...
    "++" ...
    "--" ...
    "+" ...
    "-" ...
    "*" ...
    "/" ...
    "&" ...
    "|" ...
    "^" ...
    "%" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    "<" ...
    "<" ...
    ")" ...
    "<" ...

        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.generateParseExc
eption(JavaParser.java:11808)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.jj_consume_token
(JavaParser.java:11669)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.PrimaryPrefix(Ja
vaParser.java:3372)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.PrimaryExpressio
n(JavaParser.java:3296)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.PostfixExpressio
n(JavaParser.java:3250)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.UnaryExpressionN
otPlusMinus(JavaParser.java:3158)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.UnaryExpression(
JavaParser.java:3092)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.MultiplicativeEx
pression(JavaParser.java:3012)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.AdditiveExpressi
on(JavaParser.java:2984)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ShiftExpression(
JavaParser.java:2951)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.RelationalExpres
sion(JavaParser.java:2915)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.InstanceOfExpres
sion(JavaParser.java:2902)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.AssigmentExpress
ion(JavaParser.java:2885)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.EqualityExpressi
on(JavaParser.java:2857)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.AndExpression(Ja
vaParser.java:2832)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ExclusiveOrExpre
ssion(JavaParser.java:2816)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.InclusiveOrExpre
ssion(JavaParser.java:2800)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ConditionalAndEx
pression(JavaParser.java:2795)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ConditionalOrExp
ression(JavaParser.java:2766)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ConditionalExpre
ssion(JavaParser.java:2750)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Expression(JavaP
arser.java:2694)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.IfStatement(Java
Parser.java:4145)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Statement(JavaPa
rser.java:3709)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.BlockStatement(J
avaParser.java:3892)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Block(JavaParser
.java:3841)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Statement(JavaPa
rser.java:3670)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ForStatement(Jav
aParser.java:4356)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Statement(JavaPa
rser.java:3721)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.BlockStatement(J
avaParser.java:3892)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Block(JavaParser
.java:3841)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Statement(JavaPa
rser.java:3670)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.WhileStatement(J
avaParser.java:4168)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Statement(JavaPa
rser.java:3713)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.BlockStatement(J
avaParser.java:3892)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Block(JavaParser
.java:3841)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.MethodDeclaratio
n(JavaParser.java:1972)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ClassBodyDeclara
tion(JavaParser.java:1049)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ClassBody(JavaPa
rser.java:911)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.UnmodifiedClassD
eclaration(JavaParser.java:838)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ClassDeclaration
(JavaParser.java:743)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.TypeDeclaration(
JavaParser.java:592)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.CompilationUnit(
JavaParser.java:340)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.parse(JavaParser
.java:137)
        at 
net.sourceforge.cobertura.javancss.Javancss._measureSource(Javancss.j
ava:208)
        at 
net.sourceforge.cobertura.javancss.Javancss._measureRoot(Javancss.jav
a:284)
        at 
net.sourceforge.cobertura.javancss.Javancss.<init>(Javancss.java:362)

        at 
net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlate
dCCNForSource(ComplexityCalculator.java:102)
        at 
net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlate
dCCNForSingleFile(ComplexityCalculator.java:140)
        at 
net.sourceforge.cobertura.reporting.ComplexityCalculator.getCCNForSou
rceFileNameInternal(ComplexityCalculator.java:231)
        at 
net.sourceforge.cobertura.reporting.ComplexityCalculator.getCCNForPac
kageInternal(ComplexityCalculator.java:198)
        at 
net.sourceforge.cobertura.reporting.ComplexityCalculator.getCCNForPro
ject(ComplexityCalculator.java:164)
        at 
net.sourceforge.cobertura.reporting.html.HTMLReport.generateTableRowF
orTotal(HTMLReport.java:603)
        at 
net.sourceforge.cobertura.reporting.html.HTMLReport.generateOverview(
HTMLReport.java:287)
        at 
net.sourceforge.cobertura.reporting.html.HTMLReport.generateOverviews
(HTMLReport.java:228)
        at 
net.sourceforge.cobertura.reporting.html.HTMLReport.<init>(HTMLReport
.java:71)
        at 
net.sourceforge.cobertura.reporting.Main.parseArguments(Main.java:103
)
        at net.sourceforge.cobertura.reporting.Main.main(Main.java:169)
net.sourceforge.cobertura.javancss.parser.ParseException: Encountered 
" "+=" "+=
 "" at line 1687, column 30.
Was expecting one of:
    "instanceof" ...
    ")" ...
    "=" ...
    ">" ...
    "<" ...
    "?" ...
    "==" ...
    "<=" ...
    ">=" ...
    "!=" ...
    "||" ...
    "&&" ...
    "++" ...
    "--" ...
    "+" ...
    "-" ...
    "*" ...
    "/" ...
    "&" ...
    "|" ...
    "^" ...
    "%" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    ">" ...
    "<" ...
    "<" ...
    ")" ...
    "<" ...

        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.generateParseExc
eption(JavaParser.java:11808)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.jj_consume_token
(JavaParser.java:11669)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.PrimaryPrefix(Ja
vaParser.java:3372)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.PrimaryExpressio
n(JavaParser.java:3296)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.PostfixExpressio
n(JavaParser.java:3250)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.UnaryExpressionN
otPlusMinus(JavaParser.java:3158)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.UnaryExpression(
JavaParser.java:3092)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.MultiplicativeEx
pression(JavaParser.java:3012)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.AdditiveExpressi
on(JavaParser.java:2984)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ShiftExpression(
JavaParser.java:2951)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.RelationalExpres
sion(JavaParser.java:2915)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.InstanceOfExpres
sion(JavaParser.java:2902)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.AssigmentExpress
ion(JavaParser.java:2885)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.EqualityExpressi
on(JavaParser.java:2857)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.AndExpression(Ja
vaParser.java:2832)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ExclusiveOrExpre
ssion(JavaParser.java:2816)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.InclusiveOrExpre
ssion(JavaParser.java:2800)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ConditionalAndEx
pression(JavaParser.java:2795)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ConditionalOrExp
ression(JavaParser.java:2766)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ConditionalExpre
ssion(JavaParser.java:2750)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Expression(JavaP
arser.java:2694)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.IfStatement(Java
Parser.java:4145)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Statement(JavaPa
rser.java:3709)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.BlockStatement(J
avaParser.java:3892)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Block(JavaParser
.java:3841)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Statement(JavaPa
rser.java:3670)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ForStatement(Jav
aParser.java:4356)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Statement(JavaPa
rser.java:3721)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.BlockStatement(J
avaParser.java:3892)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Block(JavaParser
.java:3841)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Statement(JavaPa
rser.java:3670)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.WhileStatement(J
avaParser.java:4168)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Statement(JavaPa
rser.java:3713)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.BlockStatement(J
avaParser.java:3892)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.Block(JavaParser
.java:3841)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.MethodDeclaratio
n(JavaParser.java:1972)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ClassBodyDeclara
tion(JavaParser.java:1049)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ClassBody(JavaPa
rser.java:911)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.UnmodifiedClassD
eclaration(JavaParser.java:838)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.ClassDeclaration
(JavaParser.java:743)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.TypeDeclaration(
JavaParser.java:592)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.CompilationUnit(
JavaParser.java:340)
        at 
net.sourceforge.cobertura.javancss.parser.JavaParser.parse(JavaParser
.java:137)
        at 
net.sourceforge.cobertura.javancss.Javancss._measureSource(Javancss.j
ava:208)
        at 
net.sourceforge.cobertura.javancss.Javancss._measureRoot(Javancss.jav
a:284)
        at 
net.sourceforge.cobertura.javancss.Javancss.<init>(Javancss.java:362)

        at 
net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlate
dCCNForSource(ComplexityCalculator.java:102)
        at 
net.sourceforge.cobertura.reporting.ComplexityCalculator.getAccumlate
dCCNForSingleFile(ComplexityCalculator.java:140)
        at 
net.sourceforge.cobertura.reporting.ComplexityCalculator.getCCNForSou
rceFileNameInternal(ComplexityCalculator.java:231)
        at 
net.sourceforge.cobertura.reporting.ComplexityCalculator.getCCNForPac
kageInternal(ComplexityCalculator.java:198)
        at 
net.sourceforge.cobertura.reporting.ComplexityCalculator.getCCNForPro
ject(ComplexityCalculator.java:164)
        at 
net.sourceforge.cobertura.reporting.html.HTMLReport.generateTableRowF
orTotal(HTMLReport.java:603)
        at 
net.sourceforge.cobertura.reporting.html.HTMLReport.generateOverview(
HTMLReport.java:287)
        at 
net.sourceforge.cobertura.reporting.html.HTMLReport.generateOverviews
(HTMLReport.java:228)
        at 
net.sourceforge.cobertura.reporting.html.HTMLReport.<init>(HTMLReport
.java:71)
        at 
net.sourceforge.cobertura.reporting.Main.parseArguments(Main.java:103
)
        at net.sourceforge.cobertura.reporting.Main.main(Main.java:169)

[INFO] Cobertura Report generation was successful.
[INFO] 
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] 
------------------------------------------------------------------------
[INFO] Total time: 5:50.619s
[INFO] Finished at: Tue Jul 09 19:57:41 CEST 2013
[INFO] Final Memory: 16M/91M
[INFO] 
------------------------------------------------------------------------



On Sun, 07 Jul 2013 18:56:46 +0200, Steven Christou 
<schristo...@gmail.com> wrote:

Sorry everyone, I made a mistake when performing the release of this,
however I just re-released  it so we can still use the same vote here.

The only difference is the Exclusive link has changed:
https://nexus.codehaus.org/content/repositories/orgcodehausmojo-107/org/codehaus/mojo/cobertura-maven-plugin/2.6/ 


Thanks and happy voting,
Steve.

On 07/07/2013 09:12 AM, Steven Christou wrote:
Hi,

I'd like to release version 2.6 of the Cobertura-Maven-Plugin

This plugin provides the features of Cobertura within the Maven 2 & 3
environment.

We solved 2 issues:
Release Notes - Maven 2.x Cobertura Plugin - Version 2.6
** Improvement
    * [MCOBERTURA-175] - Upgrade to Cobertura 2.0
    * [MCOBERTURA-176] - Add support for new feature IgnoreTrivial and
IgnoreMethodAnnotation in cobertura 2.0 (Thank you David Ignjic)

Please understand that some of the bugs for this plugin are also on
the cobertura github page which a lot of the cobertura-maven bugs have
also been logged to. Here are a few:
https://github.com/cobertura/cobertura/issues/18
https://github.com/cobertura/cobertura/issues/9

Staging Repositories:
General:
https://nexus.codehaus.org/content/groups/staging/org/codehaus/mojo/cobertura-maven-plugin/2.6/ 

Exclusive:
https://nexus.codehaus.org/content/repositories/orgcodehausmojo-106/org/codehaus/mojo/cobertura-maven-plugin/2.6/ 


(Staging) Site:
https://dav.codehaus.org/mojo/cobertura-maven-plugin/

(Current) Site:
http://mojo.codehaus.org/cobertura-maven-plugin/

SCM Tag:
http://svn.codehaus.org/mojo/tags/cobertura-maven-plugin-2.6/

ADDITIONAL_INFORMATION

 [ ] +1
 [ ] +0
 [ ] -1

The vote is open for 72 hours and will succeed by lazy consensus.



Regards Cheers

Steven Christou





---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email