Hi there,thanks again. So now everything is clear. I was already aware that this was only a quick-fix, but I did not properly test with various maven versions to see that it is so weak.
@Karl Heinz: Thanks for taking care!
I re-opened MOJO-2042 and we have to find a proper fix. -1, the vote is closed and we will need another run. Regards Jörg Am 01.10.2014 22:50, schrieb Robert Scholte:
Hmmm, I really need to investigate this, this "central"-check doesn't feel right.And Karl-Heinz is right: over the years there have been multiple URLs pointing to Maven Central. The one below is M3.2.3+ specific.thanks, RobertOp Tue, 30 Sep 2014 23:46:48 +0200 schreef Jörg Hohwiller <jo...@j-hohwiller.de>:Hi Robert, thanks also for your feedback and testing. So something is wrong. But I just checked out the tag again and "mvn verify" succeeds - no error with external-parent. C:\flatten-maven-plugin-1.0.0-beta-3>mvn -v Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; 2014-08-11T22:58:1 0+02:00) Maven home: C:\software\maven Java version: 1.7.0_67, vendor: Oracle Corporation Java home: C:\software\java\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 7", version: "6.1", arch: "x86", family: "windows" The Mojo contains this: private boolean isCentralRepositoryFromSuperPom( Repository repo ) { if ( "central".equals( repo.getId() ) ) { if ( "https://repo.maven.apache.org/maven2".equals( repo.getUrl() ) ) { if ( !repo.getSnapshots().isEnabled() ) { return true; } } } return false; } Any ideas what makes the difference? Different maven version using different super POM with central URL pointing to repo1.maven.org? Thanks Jörg Am 28.09.2014 21:58, schrieb Robert Scholte:Hi, FYI: I'm having the same issue as Karl-Heinz: the external-parent IT fails. I've checked out http://svn.codehaus.org/mojo/tags/flatten-maven-plugin-1.0.0-beta-3/ and executed 'mvn verify'. Robert Op Sun, 28 Sep 2014 20:42:28 +0200 schreef Jörg Hohwiller <jo...@j-hohwiller.de>:Hi Karl Heinz, thanks again for your testing. In your case it seems to look as if this issue was still present: http://jira.codehaus.org/browse/MOJO-2042 However, I can not reproduce this. Are you sure that you did not accidentially test with a beta3-SNAPSHOT without the fix? I also checked out the tag and "mvn install" runs smooth (no local changes).I would need precise description or script how you were running the testso I could reproduce the bug. Thanks Jörg Am 27.09.2014 14:14, schrieb Karl Heinz Marbaise:Hi, I've tested with the following Maven 3.0.5, 3.1.1, 3.2.1 with the following environment: Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19 14:51:28+0100) Maven home: /usr/share/maven Java version: 1.7.0_21, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_21.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.8.5", arch: "x86_64", family: "mac" and got the following result for all three version of Maven: [INFO] --- maven-invoker-plugin:1.8:verify (default) @ flatten-maven-plugin --- [INFO] ------------------------------------------------- [INFO] Build Summary: [INFO] Passed: 23, Failed: 1, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------- [ERROR] The following builds failed: [ERROR] * external-parent/pom.xml [INFO] ------------------------------------------------- [INFO]------------------------------------------------------------------------[INFO] BUILD FAILURE [INFO]------------------------------------------------------------------------I have attached the appropriate log file of the integration test for further analysis... On 9/24/14 10:43 PM, Jörg Hohwiller wrote:Hi, I'd like to release version 1.0.0-beta-3 of the flatten-maven-plugin Flatten Maven Plugin generates a flattened version of your pom.xmland makes maven to install and deploy this one instead of the originalpom.xml. These issues have been fixed: http://jira.codehaus.org/browse/MOJO-2032 http://jira.codehaus.org/browse/MOJO-2038 http://jira.codehaus.org/browse/MOJO-2039 http://jira.codehaus.org/browse/MOJO-2042 Staging Repositories:https://nexus.codehaus.org/content/groups/staging/org/codehaus/mojo/flatten-maven-plugin/(Staging) Site: http://mojo.codehaus.org/flatten-maven-plugin/ SCM Tag: http://svn.codehaus.org/mojo/tags/flatten-maven-plugin-1.0.0-beta-3/ There is a new feature request open that we plan for beta-4: http://jira.codehaus.org/browse/MOJO-2041 Please vote: [ ] +1 [ ] +0 [ ] -1 The vote is open for 72 hours and will succeed by lazy consensus. Regards JörgKind regards Karl-Heinz Marbaise --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email--------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
smime.p7s
Description: S/MIME Cryptographic Signature
