+1 Additionally, we might make use of the GitHub review feature and add the restriction that a PR can only be merged if it passed the required CI checks and has at least one approval.
Am 16.12.2017 2:00 vorm. schrieb "Bhavin Thaker" <[email protected]>: > Hi All, > > I would like to propose the following change to the Development process for > Apache MXNet documented here: > > https://cwiki.apache.org/confluence/display/MXNET/Development+Process > > Proposed but NOT agreed upon yet: > > > > - > > a) It is NOT recommended for a committer to merge pull requests that the > committer authored. Instead the committer MUST get at least one approval > from another committer to merge his/her pull request. > > > - b) When you update a pull request with upstream, you MUST use rebase > to ensure that the pull request is easy to review by the community. See > the > how-to link here: > https://mxnet.incubator.apache.org/community/contribute.html > > > Please vote and provide your feedback. > > Regards, > Bhavin Thaker. >
