Hi Asmus, I do understand where the concern comes from. PR 8302 is indeed a large PR that changed a lot of code and still requires more efforts for review and fully test the changes. To provide some context, PR 8302 is a refactoring and improvement of PR 7931 based on review comments in 7931 so that the MKL integration is more modular and maintainable. Da (the main contributor of the PR) posted a design doc on Apache wiki to help people understand the design of the integration (https://cwiki.apache.org/confluence/display/MXNET/The+design+of+MKLDNN+integration). As there're still some final issues (code review and test coverage) to address for this PR. In my opinion, we should try our best to address these issues in the next few days, re-evaluate whether the integration is in a decent state, and make a decision on whether to include it in the 1.0.1 release then. In the meanwhile, I would like to strongly encourage to help to review the outstanding PRs and reduce the backlog. Best, Haibin
On 2018-01-11 06:41, Asmus Hetzel <asmushet...@yahoo.de.INVALID> wrote: > Hello Haibin, > we have the following in the release notes under performance improvements: >     "Integrated MKLDNN for CPU training and inference acceleration" > My impression is that this is what PR 8302 is about. I browsed through the > code and understand and agree what this PR is trying to achieve. But must > admit that I would feel uncomfortable to wrap this up into a release schedule > that early. This PR touches 115 files in a sometimes intrusive way and is not > yet finally tested nor integrated into the master branch. Wrapping such a PR > in very lately will put a big risk on the release that we should only take > when absolutely unavoidable.I personally would either remove this from the > release or otherwise move the release date. > Let me know if I misunderstood anything. > Regards > Asmus > > > > > > Am Donnerstag, 11. Januar 2018, 00:34:04 MEZ hat Haibin Lin > <haibin.lin....@gmail.com> Folgendes geschrieben: > > I am starting the process to prepare for MXNET 1.0.1 release. I have > drafted release notes > (*https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incubating%29+1.0.1+Release+Notes > <https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incubating%29+1.0.1+Release+Notes>*) > to cover the tasks under this release. > > A release candidate will be cut on Monday 22nd Jan, 2018 and voting will > commence from then till Thursday 25th Jan, 2018. If you have any additional > features in progress and would like to include it in this release, please > assure they have been merged by Thursday 18th Jan, 2018 with comment so I > may update the release notes. > > Feel free to add any other comments/suggestions. > > Thanks, > Haibin >
