+1, but do not understand why we merged PRs which was not completely approved?
On Thu, Feb 1, 2018 at 4:20 PM, Sheng Zha <[email protected]> wrote: > Hi, > > In order to avoid having miscommunication and unaligned expectation, I'd > like to propose a lazy vote on a new rule for merging pull requests. > Specifically, for merging PRs, if there are open review comments and > changes afterwards didn’t address the comments, we should have a > grace-period of 24 hours for commenters to respond to the changes. > > This rule should take effect on Feb. 6th if there's no objection. Thanks. > > Bests, > Sheng >
