Also, if a committer clicked "request changes" as their review (which shows near the CI build info), then they need to release that -- it can't be merged -- a "request changes" to me means "-1".
On Thu, Feb 1, 2018 at 5:06 PM, Marco de Abreu <marco.g.ab...@googlemail.com > wrote: > Additionally, I'd like to propose to add that people with open requested > changes actively have to be pinged and that the 24 hours only start after > that ping. Was that part of your intention, Sheng? > > -Marco > > On Thu, Feb 1, 2018 at 4:29 PM, Nan Zhu <zhunanmcg...@gmail.com> wrote: > > > +1, but do not understand why we merged PRs which was not completely > > approved? > > > > On Thu, Feb 1, 2018 at 4:20 PM, Sheng Zha <zhash...@apache.org> wrote: > > > > > Hi, > > > > > > In order to avoid having miscommunication and unaligned expectation, > I'd > > > like to propose a lazy vote on a new rule for merging pull requests. > > > Specifically, for merging PRs, if there are open review comments and > > > changes afterwards didn’t address the comments, we should have a > > > grace-period of 24 hours for commenters to respond to the changes. > > > > > > This rule should take effect on Feb. 6th if there's no objection. > Thanks. > > > > > > Bests, > > > Sheng > > > > > >
