I can confirm that #10989’s corresponding commit 022f238 is not on the release branch. Fix of #11772 on master is in #11776.
-sz > On Jul 16, 2018, at 8:23 PM, Afrooze, Sina <[email protected]> > wrote: > > Thanks Anirudh for checking. Looks like the PR for adding model summary > feature (https://github.com/apache/incubator-mxnet/pull/10989) introduced > this regression. This change isn't included in 1.2.0 or 1.2.1 , so 1.2.1 > should be good. > > @szha: Can you please double check and confirm that 1.2.1 is indeed not > impacted? > > - Sina > > On 7/16/18, 5:46 PM, "Anirudh" <[email protected]> wrote: > > Hi Sina, > > I am unable to reproduce this issue on 1.2.1. > > Anirudh > >> On Mon, Jul 16, 2018 at 5:26 PM, Afrooze, Sina <[email protected]> wrote: >> >> I know voting is over for this release, but I think this issue may warrant >> delaying: https://github.com/apache/incubator-mxnet/issues/11772. Looks >> like save_parameters doesn't fix the issue it is designed to fix (i.e. two >> instances of the same network in the same session) if LSTMs are used. >> >> - Sina >> >> On 7/12/18, 3:27 PM, "Hao Jin" <[email protected]> wrote: >> >> +1 Built on Ubuntu with CUDA 9.0 and CuDNN 7 and verified that sparse >> tests >> are passing. >> Hao >> >> On Thu, Jul 12, 2018 at 3:01 PM, Sergio Fernández <[email protected]> >> wrote: >> >>> +1 (binding) >>> >>> On Mon, Jul 9, 2018, 16:53 Roshani Nagmote < >> [email protected]> >>> wrote: >>> >>>> Hi all, >>>> >>>> I would like to propose a vote to release Apache MXNet (incubating) >>> version >>>> 1.2.1.RC1. Voting will start now (Monday, Jul 9th) and end at 5:50 >> PM >>>> PDT, Thursday, July 12th. >>>> >>>> Link to release candidate 1.2.1.rc1: >>>> *https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc1 >>>> <https://github.com/apache/incubator-mxnet/releases/tag/1.2.1.rc1 >>> * >>>> >>>> View this page, click on "Build from Source", and use the source >> code >>>> obtained from 1.2.1.rc1 tag: >>>> https://mxnet.incubator.apache.org/install/index.html >>>> >>>> (Note: The README.md points to the 1.2.1 tag and does not work at >> the >>>> moment.) >>>> >>>> Please remember to test first before voting accordingly: >>>> >>>> +1 = approve >>>> +0 = no opinion >>>> -1 = disapprove (provide reason) >>>> >>>> Thanks, >>>> Roshani >>>> >>> >> >> >> >> > >
