I thought about it some more, and I don't think these are blockers. +1 non-binding
Here's why: For 1) The website splits things out properly and that's the primary use case. If there's a demand for it, the jars for the docs can be build per version and split out as needed, and these can be provided for download. For 2) This is an issue when you use a more recent version of Scala than what we have in our CI and Ubuntu dependencies. It really only pops up if you want to build scala, and you have the latest scala from brew or if you have specifically upgraded scala on Ubuntu (where it seems to be lagging a bit behind the version mac is using by default). The release notes can have an entry that informs people three different ways to resolve the issue: how to turn off the scala docs build in the docss/settings.ini file, or the scala version to use, or the line to update in mxdoc.py to get around the issue. For the next release, we could upgrade scala in the dependencies and provide a little better cross-platform support, but either way it shouldn't happen in v1.4 since it's already patched in master. Cheers, Aaron On Sat, Nov 17, 2018 at 1:05 PM Aaron Markham <aaron.s.mark...@gmail.com> wrote: > > Website and docs for 1.3.x branch is working fine. However... > > Two things to note that could be blockers: > 1) The Scala API going out with the JavaAPI bundled inside it: > /api/scala/docs/index.html#org.apache.mxnet.javaapi.package - this is > fixed in master with #13071. > 2) `make docs` doesn't work when you checkout v1.3.x branch on its > own. The scala docs step breaks the build. I tested a fix with one > update from the same Java/Scala docs PR I put in 4 days ago: > https://github.com/apache/incubator-mxnet/pull/13071/files#diff-c8ca1b4ea12114fbd742c76087bca0e4R121 > This appears to fix the issue. (Scala version differences create > different artifacts which may cause that step to fail.) I can create a > PR for just this one change. I wouldn't apply #13071 - I tried it and > it failed with Java-related dependency errors. If we want to fix both, > then, maybe we can tackle that and the other errors and warnings that > were just introduced with the Java API too. > On Fri, Nov 16, 2018 at 8:44 PM sandeep krishnamurthy > <sandeep.krishn...@gmail.com> wrote: > > > > +1 > > > > Build from source on Mac and Ubuntu 16.04. > > > > 1. Run GAN, DCGAN using Gluon on 1 GPU in Ubuntu and CPU Mac. > > 2. Convert a model to fp16, save and load in Gluon, perform inference. > > > > Best, > > Sandeep > > > > On Fri, Nov 16, 2018, 7:01 PM Indhu <indhubhara...@gmail.com wrote: > > > > > +1. > > > > > > Builds fine from source. Tested few CNN examples using Python binding. > > > Everything looks fine. > > > > > > Thanks, > > > Indu > > > > > > > > > On Fri, Nov 16, 2018, 4:16 PM Roshani Nagmote <roshaninagmo...@gmail.com > > > wrote: > > > > > > > +1 > > > > Installed the release package on Ubuntu with CUDA, CUDNN enabled and ran > > > > train_cifar10.py example successfully. > > > > > > > > Thanks, > > > > Roshani > > > > > > > > On Fri, Nov 16, 2018 at 5:21 AM Anton Chernov <mecher...@gmail.com> > > > wrote: > > > > > > > > > Thank you Carin, Steffen and Kellen for your votes. > > > > > > > > > > The results so far: > > > > > > > > > > * Binding * > > > > > > > > > > +1 votes: > > > > > - Carin > > > > > > > > > > * Non-Binding * > > > > > > > > > > +1 votes: > > > > > - Kellen > > > > > - Steffen > > > > > > > > > > So far, we've got only positive votes, but unfortunately not enough to > > > > > conclude a result from the vote. I would like to remind everyone that > > > we > > > > > need at least 3 binding +1 votes. Therefore, the vote is extended > > > > > until > > > > > Tuesday 20th of November 2018, 5pm CET (9am PT). > > > > > > > > > > I kindly ask the community to participate in voting for this patch > > > > release. > > > > > > > > > > Best regards > > > > > Anton > > > > > > > > > > > > > > > пт, 16 нояб. 2018 г. в 9:10, kellen sunderland < > > > > > kellen.sunderl...@gmail.com > > > > > >: > > > > > > > > > > > Just tested with 1.3.0 and those tests were failing for that release > > > as > > > > > > well. Given it's not a regression I'm +1 (non-binding). > > > > > > > > > > > > On Thu, Nov 15, 2018 at 11:52 PM kellen sunderland < > > > > > > kellen.sunderl...@gmail.com> wrote: > > > > > > > > > > > > > Thanks for organizing the release Anton and for testing Carin and > > > > > > > Steffen. Lots of great fixes in this release. As we don't have > > > the > > > > > > > required 3 committers I'd suggest extending the vote for a few > > > days. > > > > > > > > > > > > > > I tested the following on MacOS 10.13, High Sierra: > > > > > > > > > > > > > > INCUBATING IN RELEASE FILE: check. > > > > > > > LICENSE check. > > > > > > > NOTICE check. > > > > > > > SIGNATURE check. > > > > > > > HASH check. > > > > > > > DISCLAIMER check. > > > > > > > SOURCE COMPILES VIA MAKEFILE check. > > > > > > > SOURCE COMPILES VIA CMAKE check. > > > > > > > C++ TESTS PASS fail > > > > > > > Two tests failing for me. > > > > > > > Build with flags: cmake -DUSE_CUDA=0 -DUSE_CUDNN=0 -DUSE_OPENMP=0 > > > > > > > -DUSE_OPENCV=0 .. > > > > > > > Ran c++ tests with exclusions: ./tests/mxnet_unit_tests > > > > > > > --gtest_filter=-GpuTopology.* > > > > > > > Result: > > > > > > > [ FAILED ] 2 tests, listed below: > > > > > > > [ FAILED ] ACTIVATION_PERF.ExecuteBidirectional > > > > > > > [ FAILED ] ACTIVATION_PERF.TimingCPU > > > > > > > > > > > > > > PYHTON UNIT TESTS PASS check. > > > > > > > > > > > > > > Not sure if the test failures are a regression so I'm +0 > > > > (non-binding) > > > > > > > > > > > > > > On Thu, Nov 15, 2018 at 5:43 PM Steffen Rochel < > > > > > steffenroc...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > >> +1 build on MacOS Sierra following instructions on > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/MXNet+Developer+Setup+on+Mac > > > > > > >> and run one training test. > > > > > > >> > > > > > > >> On Tue, Nov 13, 2018 at 2:34 PM Carin Meier <carinme...@gmail.com > > > > > > > > > > wrote: > > > > > > >> > > > > > > >> > +1 - Clojure package tested fine with Scala jars > > > > > > >> > > > > > > > >> > On Mon, Nov 12, 2018 at 6:53 PM Anton Chernov < > > > > mecher...@gmail.com> > > > > > > >> wrote: > > > > > > >> > > > > > > > >> > > Dear MXNet community, > > > > > > >> > > > > > > > > >> > > This is the vote to release Apache MXNet (incubating) version > > > > > 1.3.1. > > > > > > >> > Voting > > > > > > >> > > will start now, on Monday the 12th of November 2018 and close > > > on > > > > > > 14:00 > > > > > > >> > > Thursday the 15th of November 2018, Pacific Time (PT). > > > > > > >> > > > > > > > > >> > > Link to release notes: > > > > > > >> > > https://cwiki.apache.org/confluence/x/eZGzBQ > > > > > > >> > > > > > > > > >> > > Link to release candidate 1.3.1.rc0: > > > > > > >> > > > > > > https://github.com/apache/incubator-mxnet/releases/tag/1.3.1.rc0 > > > > > > >> > > > > > > > > >> > > Link to source and signatures on apache dist server: > > > > > > >> > > > > > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.3.1.rc0/ > > > > > > >> > > > > > > > > >> > > Link to scala packages on the staging repo: > > > > > > >> > > > > > > > > >> > > * CPU > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/snapshots/org/apache/mxnet/mxnet-full_2.11-osx-x86_64-cpu/1.3.1-SNAPSHOT/ > > > > > > >> > > > > > > > > >> > > * GPU > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/snapshots/org/apache/mxnet/mxnet-full_2.11-linux-x86_64-gpu/1.3.1-SNAPSHOT/ > > > > > > >> > > > > > > > > >> > > Please remember to TEST first before voting accordingly: > > > > > > >> > > +1 = approve > > > > > > >> > > +0 = no opinion > > > > > > >> > > -1 = disapprove (provide reason) > > > > > > >> > > > > > > > > >> > > > > > > > > >> > > Best regards, > > > > > > >> > > Anton > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > >
