Hi Steffen, I have created a PR to cherry pick the change to v1.4.x branch: https://github.com/apache/incubator-mxnet/pull/13517
Anirudh On Mon, Dec 3, 2018 at 11:29 AM Steffen Rochel <[email protected]> wrote: > Thanks Haibin. Anirudh - please add PR for v1.4.x for > https://github.com/apache/incubator-mxnet/pull/13501 > Steffen > > On Mon, Dec 3, 2018 at 10:55 AM Haibin Lin <[email protected]> > wrote: > > > It would also be great to include the PR that reverts a commit causing > cpu > > performance degradation > > https://github.com/apache/incubator-mxnet/pull/13501, > > where num_omp_threads decrease to 1 when multiple GPUs are used, as > Anirudh > > reported in > > > > > https://github.com/apache/incubator-mxnet/issues/13449#issuecomment-443388522 > > < > > > https://github.com/apache/incubator-mxnet/issues/13449#issuecomment-443388522 > > > > > > > Best, > > Haibin > > > > On Mon, Dec 3, 2018 at 10:50 AM Afrooze, Sina <[email protected]> > wrote: > > > > > I would also like this PR which is already merged with master ( > > > https://github.com/apache/incubator-mxnet/pull/13426) to be included > in > > > 1.4.0 to avoid any potential ONNX export issues in cases where the API > is > > > not used strictly correctly. - Sina > > > > > > > > > > > > On 11/30/18, 2:17 PM, "Alex Zai" <[email protected]> wrote: > > > > > > PR is here https://github.com/apache/incubator-mxnet/pull/13497. > > > > > > On Thu, Nov 29, 2018 at 8:56 PM Lv, Tao A <[email protected]> > > wrote: > > > > > > > Credit belongs to Alex. > > > > > > > > Hi Alex, would you mind porting your fix to the v1.4.x branch? > > > > > > > > Thanks, > > > > -Tao > > > > > > > > -----Original Message----- > > > > From: Steffen Rochel [mailto:[email protected]] > > > > Sent: Friday, November 30, 2018 12:48 PM > > > > To: [email protected] > > > > Subject: Re: v1.4.0 status 11/29 > > > > > > > > Hi Tao - thanks for fixing the crash. Please create PR on v1.4.x > > > branch > > > > with [v1.4.x] in title and add me to the PR. > > > > Steffen > > > > > > > > On Thu, Nov 29, 2018 at 8:44 PM Lv, Tao A <[email protected]> > > > wrote: > > > > > > > > > Hi Steffen, I would like to have > > > > > https://github.com/apache/incubator-mxnet/pull/13433 into the > > > coming > > > > > 1.4.0 release. It fixed a crash of deconvolution with certain > > input > > > > > size for MKL-DNN backend. This PR is well reviewed and already > > > merged > > > > > into the master branch. New test case is also included there. > > > > > > > > > > Please find the corresponding issue here: > > > > > https://github.com/apache/incubator-mxnet/issues/13421 . > > > > > > > > > > Thanks, > > > > > -Tao > > > > > > > > > > -----Original Message----- > > > > > From: Steffen Rochel [mailto:[email protected]] > > > > > Sent: Friday, November 30, 2018 12:05 PM > > > > > To: [email protected] > > > > > Subject: v1.4.0 status 11/29 > > > > > > > > > > Dear MXNet community - > > > > > I would like to provide update on v1.4.0 status, details will > be > > > > > tracked here < > > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incu > > > > > bating%29+1.4.0+Release+Plan+and+Status > > > > > > > > > > > . > > > > > > > > > > 1. Sergey created v1.4.x branch > > > > > 2. As expected, additional requests have been made for > inclusion > > in > > > > > v1.4.0 release. Critical PR are tracked here < > > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incu > > > > > > > > bating%29+1.4.0+Release+Plan+and+Status#ApacheMXNet(incubating)1.4.0Re > > > > > leasePlanandStatus-OpenPRstotrack > > > > > > > > > > > . > > > > > 3. PR to update README.md is blocked by flaky test failures, > > > > > retriggered check. > > > > > 4. PR to upgrade version on master to v1.5.0 has been > submitted. > > > > > 5. CI is setup and first run passed. > > > > > > > > > > Note: if you want to add selected fixes or enhancements, please > > > reply > > > > > to this email. Please provide justification, add me as approver > > to > > > the > > > > > v1.4.x PR and make sure your changes have tests included in PR > > and > > > get > > > > > properly reviewed. > > > > > > > > > > Regards, > > > > > Steffen > > > > > > > > > > > > > > > > > > > > > > > >
