-[Y] Are release files in correct location?
-[Y] Do release files have the word incubating in their name?
-[Y] Are the digital signature and hashes correct?
-[Y] Does DISCLAIMER file exist?
-[Y] Do LICENSE and NOTICE files exists?
-[Y] Is the LICENSE and NOTICE text correct?
-[N] Is the NOTICE year correct?
-[Y] Un-included software dependencies are not mentioned in LICENSE or NOTICE? 
(sz: did not finish checking)
-[Y] License information is not mentioned in NOTICE?
Is there any 3rd party code contained inside the release? If so:
-[Y] Does the software have a compatible license?
-[Y] Are all software licenses mentioned in LICENSE?
-[Y] Is the full text of the licenses (or pointers to it) in LICENSE?
Is any of this code Apache licensed? Do they have NOTICE files? If so:
-[Y] Have relevant parts of those NOTICE files been added to this NOTICE
file?
-[Y] Do all source files have ASF headers?
-[Y] Do the contents of the release match with what's tagged in version control?
-[N] Are there any unexpected binary files in the release?
-[Y] Can you compile from source? Are the instruction clear?

+1 with the caveat:
- NOTICE year was fixed on master but not on the release candidate. rc3 still 
reads "2017-2018"

-sz

On 2019/02/19 00:19:52, Roshani Nagmote <roshaninagmo...@gmail.com> wrote: 
> +1 Downloaded, installed on Ubuntu 16.04. Verified signatures.
> Built from source with cuda enabled. Ran train_mnist.py test successfully.
> 
> Thanks,
> Roshani
> 
> On Sun, Feb 17, 2019 at 12:13 PM Carin Meier <carinme...@gmail.com> wrote:
> 
> > +1 Downloaded and verified the signature on the tar. Built and tested the
> > Scala/Clojure package
> >
> > On Sun, Feb 17, 2019 at 2:13 PM Qing Lan <lanking...@live.com> wrote:
> >
> > > +1 (binding) on the release. Checked Mac + Linux (Ubuntu 16.04) build
> > from
> > > source successfully. Checked Scala build with no errors.
> > >
> > > ´╗┐On 2/15/19, 6:08 PM, "Piyush Ghai" <ghai.piy...@gmail.com> wrote:
> > >
> > >     Dear MXNet community,
> > >
> > >     I would like to propose a vote to release Apache MXNet (incubating)
> > > version v1.4.0.
> > >     Voting will start today, Friday February 15th 6pm PST and will close
> > > on Monday,
> > >     February 18th 6pm PST.
> > >
> > >     Link to release notes:
> > >
> > >
> > >
> > https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incubating%29+1.4.0+Release+Notes
> > > <
> > >
> > https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+(incubating)+1.4.0+Release+Notes
> > > >
> > >
> > >     Link to release candidate 1.4.0.rc3:
> > >      <https://github.com/apache/incubator-mxnet/releases/tag/1.4.0.rc3/>
> > > https://github.com/apache/incubator-mxnet/releases/tag/1.4.0.rc3 <
> > > https://github.com/apache/incubator-mxnet/releases/tag/1.4.0.rc3>/
> > >
> > >     Link to source and signatures on apache dist server:
> > >     https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.0.rc3/ <
> > > https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.0.rc3/>
> > >
> > >
> > >     Please remember to TEST first before voting accordingly:
> > >     +1 = approve
> > >     +0 = no opinion
> > >     -1 = disapprove (provide reason)
> > >
> > >
> > >     Best regards,
> > >     Piyush
> > >
> > >
> >
> 

Reply via email to