In the end it only comes down to money, considering that the system is auto scaling, making the execution time constant.
If we're trading money for usability, I certainly would prefer usability. I'd rather recommend to spend time on parallelizing test execution or getting rid of integration tests in the PR stage instead reducing the costs by making people not use it. But taking a step back to requiring people to manually trigger CI again doesn't feel right. I'm happy to see that bot deployed, but I do not agree with removing the auto trigger functionality for new commits. -Marco Chaitanya Bapat <chai.ba...@gmail.com> schrieb am Do., 12. März 2020, 22:47: > @Marco Thanks for pointing that out. > Tomorrow i.e. Friday, March 13, 2020 at 3:00 PM - 3:30 PM in (UTC-08:00) > Pacific Time (US & Canada). > > > When do we expect this bot to be deployed? > @Lin If all goes well in the next week I can deploy it to public Apache > (provided I get permissions from Apache Infra) > > @Marco Thanks for your feedback. > > CI system has to support the community without requiring people to > constantly shepherd every single run > We have data for the number of times CI was triggered unnecessarily which > includes > - Entire build triggered instead of specific build > - CI triggered when PR is still work in progress or not yet ready (say - > intermediate commits) > At the end its a trade-off > Money, Resources, Time to build for each and every commit vs Pain of > triggering builds > > > > Scan trigger plugin would poll SCM. Can we use plugin at scale? > > 1. I haven't tested it on scale. But I think with the current scale of > MXNet repo (191 open PRs i.e. checking for changes to 191 branches - It > should be manageable) > 2. What's the purpose of the plugin? tldr; Branch discovery or branch > indexing. > Scan trigger plugin comes into the picture only once per PR per job (i.e. 8 > times per PR for 8 jobs). It is basically done when a new PR is made and > the job (say unix-cpu hasn't discovered the new PR branch yet). That's it. > So it shouldn't be a problem for public MXNet repo. > > Thanks, > Chai > > > On Thu, 12 Mar 2020 at 14:22, Marco de Abreu <marco.g.ab...@gmail.com> > wrote: > > > Btw you forgot to set a date and time for the metting > > > > > > On Thu, Mar 12, 2020 at 10:18 PM Marco de Abreu <marco.g.ab...@gmail.com > > > > wrote: > > > > > Thanks Chai, I generally like the idea of the bot. But I'm not a > > supporter > > > of the idea to disable any automatic triggering (disabling the webhook > is > > > also not an option, considering that this will disable master > triggers). > > > The CI system has to support the community without requiring people to > > > constantly shepherd every single run. Disabling automatic triggering > > seems > > > like a step back to me. > > > > > > Instead, I'd recommend that CI gets triggered upon every commit as > usual, > > > but people have the possibility to call a "command" (i.e. make a > message > > > which results in the bot setting a label) to disable CI until they > revoke > > > it. But the standard should still be that a new commit triggers a new > CI > > > run. > > > > > > https://plugins.jenkins.io/multibranch-scan-webhook-trigger/ seems > like > > > this would poll SCM. This will incur high quota restrictions. Are you > > sure > > > that you can use that plugin at scale? > > > > > > -Marco > > > > > > > > > On Thu, Mar 12, 2020 at 10:04 PM Lin Yuan <apefor...@gmail.com> wrote: > > > > > >> Chai, > > >> > > >> Awesome work. When do we expect this bot to be deployed? > > >> > > >> Best, > > >> > > >> Lin > > >> > > >> On Thu, Mar 12, 2020 at 2:00 PM Chaitanya Bapat <chai.ba...@gmail.com > > > > >> wrote: > > >> > > >> > Hello MXNet community, > > >> > > > >> > I have built an MXNet Bot <https://github.com/mxnet-bot> that > allows > > PR > > >> > Authors, Committers and Jenkins Admins to trigger CI manually. > > >> > It handles 2 problems > > >> > 1. Manual CI trigger instead of existing automated CI trigger > > >> > 2. Gives permissions to PR Authors (in addition to MXNet Committers > > and > > >> > Jenkins Admins) > > >> > > > >> > Design Doc : > > >> > https://cwiki.apache.org/confluence/display/MXNET/MXNet+CI+Bot > > >> > > > >> > I urge you all to attend the demonstration meeting and lend your > views > > >> on > > >> > the same. > > >> > > > >> > Thank you, > > >> > Chai > > >> > > > >> > *Meeting Details*: > > >> > ==============Conference Bridge Information============== > > >> > You have been invited to an online meeting, powered by Amazon Chime. > > >> > *Chime meeting ID*: *9272158344* > > >> > Join via Chime clients (manually): Select 'Meetings > Join a > Meeting', > > >> and > > >> > enter 9272158344 > > >> > Join via Chime clients (auto-call): If you invite auto-call as > > attendee, > > >> > Chime will call you when the meeting starts, select 'Answer' > > >> > *Join via browser screen share*: https://chime.aws/9272158344 > > >> > *Join via phone* (US): +1-929-432-4463,,,9272158344# > > >> > *Join via phone (US toll-free)*: +1-855-552-4463,,,9272158344# > > >> > International dial-in: https://chime.aws/dialinnumbers/ > > >> > In-room video system: Ext: 62000, Meeting PIN: 9272158344# > > >> > > > >> > -- > > >> > *Chaitanya Prakash Bapat* > > >> > *+1 (973) 953-6299* > > >> > > > >> > [image: https://www.linkedin.com//in/chaibapat25] > > >> > <https://github.com/ChaiBapchya>[image: > > >> https://www.facebook.com/chaibapat > > >> > ] > > >> > <https://www.facebook.com/chaibapchya>[image: > > >> > https://twitter.com/ChaiBapchya] <https://twitter.com/ChaiBapchya > > >> >[image: > > >> > https://www.linkedin.com//in/chaibapat25] > > >> > <https://www.linkedin.com//in/chaibapchya/> > > >> > > > >> > > > > > > > > -- > *Chaitanya Prakash Bapat* > *+1 (973) 953-6299* > > [image: https://www.linkedin.com//in/chaibapat25] > <https://github.com/ChaiBapchya>[image: https://www.facebook.com/chaibapat > ] > <https://www.facebook.com/chaibapchya>[image: > https://twitter.com/ChaiBapchya] <https://twitter.com/ChaiBapchya>[image: > https://www.linkedin.com//in/chaibapat25] > <https://www.linkedin.com//in/chaibapchya/> >
