CommandLink tag override onsubmit function of Form
--------------------------------------------------
Key: MYFACES-401
URL: http://issues.apache.org/jira/browse/MYFACES-401
Project: MyFaces
Type: Bug
Components: JSF 1.1
Versions: Nightly Build
Environment: Tomcat 5.0.28
Reporter: Zhong Li
Priority: Critical
I have java script onsubmit in <h:form>, when I use commandLink tag, even
onsubmit return false, the form still submitted. I checked javasctipt, If I am
right, the bug should be here,
JSF generate Javascript for each commandLink like,
clear_unitItemViewList();
document.forms['unitItemViewList'].elements['autoScroll'].value=getScrolling();
document.forms['unitItemViewList'].elements['unitItemViewList:_link_hidden_'].value='unitItemViewList:_id49_0:_id72';
if(document.forms['unitItemViewList'].onsubmit){document.forms['unitItemViewList'].onsubmit();}
document.forms['unitItemViewList'].submit();
return false;
----------------------
so problem it will be caused by
if(document.forms['unitItemViewList'].onsubmit){document.forms['unitItemViewList'].onsubmit();}
document.forms['unitItemViewList'].submit(); //the form submitted!!!!!!
it should be
if(document.forms['unitItemViewList'].onsubmit)
{
if( document.forms['unitItemViewList'].onsubmit() )
{
document.forms['unitItemViewList'].submit();
}
}
else
{
document.forms['unitItemViewList'].submit();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
