[ 
http://issues.apache.org/jira/browse/MYFACES-628?page=comments#action_12331221 
] 

Bill Dudney commented on MYFACES-628:
-------------------------------------

Hi Ronald,

Here is the logging code;

    private boolean shouldSkipPhaseProcessing(FacesContext facesContext, String 
phase, boolean before) {
                boolean flag = false;
        if (facesContext.getResponseComplete())
        {
            if (log.isDebugEnabled())
                                log.debug("exiting from lifecycle.execute in " 
+ phase
                                                + " because getResponseComplete 
is true from one of the " +
                                                (before ? "before" : "after") + 
" listeners");
            flag = true;
        }

        if (facesContext.getRenderResponse())
        {
            if (log.isDebugEnabled())
                                log.debug("exiting from lifecycle.execute in " 
+ phase
                                                + " because getRenderResponse 
is true from one of the " + 
                                                (before ? "before" : "after") + 
" listeners");
            flag = true;
        }
        return flag;
        }

I figure you know the phase lifecycle well enough that I don't have to put the 
'next phase' into the message.

> Current Lifecycle implementation violates JSF Spec 1.1
> ------------------------------------------------------
>
>          Key: MYFACES-628
>          URL: http://issues.apache.org/jira/browse/MYFACES-628
>      Project: MyFaces
>         Type: Bug
>   Components: JSR-127
>     Versions: 1.1.0
>     Reporter: Holger Schimanski
>     Assignee: Bill Dudney
>     Priority: Blocker
>      Fix For: 1.1.1

>
> If a PhaseListener.beforePhase() calles FacesContext.renderResponse() or 
> FacesContext.responseComplete(), then the LifeCycleImpl should not execute 
> the functionality required for the current phase. (see JSF Spec 1.1 section 
> 11-1 page 296f.)  LifeCycleImpl is not taking care about this. 
> This is important for us, because we'd like to make a redirect in the before 
> render response phase. And at the moment an Illegal State exception is 
> thrown, because the renderResponse is executed although responseComplete has 
> been called.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to