[ http://issues.apache.org/jira/browse/MYFACES-1034?page=comments#action_12365568 ]
Martin Marinschek commented on MYFACES-1034: -------------------------------------------- Hi Peter, Now I got to look at your patches - sorry, but they won't work as such. You are referring to the ServletContext in MyFacesConfig - this we don't want, we want to make sure we can stay with the external-context, cause if we don't do that, we get problems with casts as soon as a PortletContext is coming in. Over time, we also want to change the ExtensionsFilter away from the current state where MyFaces will fail with Portlets. regards, Martin > Allow customisable AddResource implementations > ---------------------------------------------- > > Key: MYFACES-1034 > URL: http://issues.apache.org/jira/browse/MYFACES-1034 > Project: MyFaces > Type: Improvement > Components: Tomahawk > Versions: Nightly > Reporter: Peter Mahoney > Assignee: Martin Marinschek > Attachments: AddResourcePatch.zip, DefaultAddResource.java, > addresource_patch3.zip > > I use an alternative version of the AddResource. class > The two areas which I have customised are the getResourceUri() method (which > rewrites the URL to call resources through a forwarding controller servlet) > and writeWithFullHeader() (which has different rules as to where insertions > will take place when there is no <head> or <body> tags, as the applications > only output HTML fragments). > Currently to do this a custom MyFaces has to be built. > Ideally, AddResource would be an interface. An AddResourceFactory class would > provide the getInstance() method (or equivalent). This method would check for > a context parameter specifying the implementation class to use. If not > specified, an instance of DefaultAddResource would be used. > DefaultAddResource would be non-final and would therefore be subclassed to > provide the customisations described above. > Would this be a suitable change? If so, I would be happy to implement the > change and supply a patch. > Thanks -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
