Mike,
there is no need to say "public" inside of interface
each method defined is public and abstract
same for constants.
"public static final" is not needed
all constants are
public static final String x = "x";
same as
String x = "x";
So I removed that (unnecessary) code.
On 2/15/06, Mike Kienenberger <[EMAIL PROTECTED]> wrote:
> Matthias,
>
> Pardon my ignorance, but why are we removing public from the interface?
>
> I make use of UploadedFile in my application code, and it seems like
> it should remain public.
>
> Maybe this is some nuance of java I don't understand, though.
>
> I haven't actually pulled the latest SVN snapshot yet to see if it
> makes a difference.
>
> I noticed you made the same change to
> myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/ExtendedComponentBase.java
> as well, but this seems less likely to affect end users.
>
> -Mike
>
>
> On 2/15/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
> > Author: matzew
> > Date: Wed Feb 15 04:11:56 2006
> > New Revision: 377993
> >
> > URL: http://svn.apache.org/viewcvs?rev=377993&view=rev
> > Log:
> > removed public from interface
> >
> > Modified:
> >
> > myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/fileupload/UploadedFile.java
> >
> > Modified:
> > myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/fileupload/UploadedFile.java
> > URL:
> > http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/fileupload/UploadedFile.java?rev=377993&r1=377992&r2=377993&view=diff
> > ==============================================================================
> > ---
> > myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/fileupload/UploadedFile.java
> > (original)
> > +++
> > myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/fileupload/UploadedFile.java
> > Wed Feb 15 04:11:56 2006
> > @@ -34,7 +34,7 @@
> > *
> > * @return file contents
> > */
> > - public byte[] getBytes() throws IOException;
> > + byte[] getBytes() throws IOException;
> >
> >
> > /**
> > @@ -43,25 +43,25 @@
> > * @throws IOException
> > * @return InputStream
> > */
> > - public InputStream getInputStream() throws IOException;
> > + InputStream getInputStream() throws IOException;
> >
> >
> > /**
> > * @return Returns the _contentType.
> > */
> > - public String getContentType();
> > + String getContentType();
> >
> >
> >
> > /**
> > * @return Returns the _name.
> > */
> > - public String getName();
> > + String getName();
> >
> >
> > /**
> > * Answer the size of this file.
> > * @return long
> > */
> > - public long getSize();
> > + long getSize();
> > }
> >
> >
> >
>
--
Matthias Wessendorf
Zülpicher Wall 12, 239
50674 Köln
http://www.wessendorf.net
mwessendorf-at-gmail-dot-com
