No objections at this point, but what about tomahawk? If the next release of tomahawk is to run along side w/ this release of core, it will have to be compatible w/ the only branch for shared. Are there any obstacles to this? I am at my day job now so I can't look into this too deeply.
Dennis Byrne >-----Original Message----- >From: Sean Schofield [mailto:[EMAIL PROTECTED] >Sent: Monday, March 6, 2006 01:31 PM >To: 'MyFaces Development' >Subject: Re: Testing Progress? > >OK, then I will branch the shared like we discussed. Any objections? > >Sean > >On 3/6/06, Dennis Byrne <[EMAIL PROTECTED]> wrote: >> I meant Martin's commit fixed trunk shared w/ trunk core. I'm sure you have >> already found that this is not true for the core branch. >> >> Dennis Byrne >> >> >-----Original Message----- >> >From: Sean Schofield [mailto:[EMAIL PROTECTED] >> >Sent: Monday, March 6, 2006 07:06 AM >> >To: 'MyFaces Development' >> >Subject: Re: Testing Progress? >> > >> >> Martin's last commit appears to make this work. >> > >> >It doesn't work for me. I get ... >> > >> >D:\open-source\myfaces-core-1.1.2\impl\src\main\java\org\apache\myfaces\webapp\f >> >ilter\JavaScriptDetectorFilter.java:[58,23] >> >setJavascriptDetected(javax.servlet. >> >http.HttpSession,boolean) in >> >org.apache.myfaces.shared_impl.renderkit.html.util. >> >JavascriptUtils cannot be applied to >> >(javax.faces.context.ExternalContext,boolea >> >n) >> > >> >> Dennis Byrne >> > >> >Sean >> > >> >> >> >
