Most/all of the dependencies you are talking about could be removed with Shale as well, but where is the harm in impl dependecies on tomahawk *test* ? I realize they *unit* tests but I would like to see the tests use as many production myfaces classes as possible, w/out a container. This way there is more coverage.
Shale unit testing was brought in mainly to get rid of all of our duplicate mock classes. This is done but I still plan on refactoring the Cactus stuff so we can actually use that code. Dennis Byrne >-----Original Message----- >From: Mike Kienenberger [mailto:[EMAIL PROTECTED] >Sent: Friday, March 17, 2006 11:00 AM >To: 'MyFaces Dev mailing list' >Subject: tomahawk/src/test has dependencies on MyFaces Impl > >As I'm trying to work through the setup of the current MyFaces >snapshot under Eclipse (the maven eclipse wiki pages are once again >wrong, unfortunately), I am noticing that there are dependences in >tomahawk/src/test on the MyFaces impl. > >org.apache.myfaces.custom.date.HtmlDateRendererTest.java: > import org.apache.myfaces.application.ApplicationFactoryImpl; > >org.apache.myfaces.renderkit.html.util.AddResourceTest.java: > import org.apache.myfaces.application.ApplicationFactoryImpl; > import org.apache.myfaces.renderkit.RenderKitFactoryImpl; > import org.apache.myfaces.context.servlet.ServletFacesContextImpl; > >In my opinion, this should not be the case. Is this a temporary >situation where we're waiting on Shale's testing framework? > >-Mike >
