Sean,

Thanks, Core looks good now.

Are we supposed to be testing the Tomahawk 1.1.2 branch as well, or is
the focus just on Shared and Core right now?  I ask because as it stands
right now in the branch, Tomahawk's core pom.xml is still pointing to
myfaces-shared-impl-2.0.0-SNAPSHOT.jar.

Jeremy

-----Original Message-----
From: Sean Schofield [mailto:[EMAIL PROTECTED] 
Sent: Wednesday, April 12, 2006 8:03 PM
To: MyFaces Development
Subject: Re: Core 1.1.2 Branch - Incorrect Dependency?

Jeremy,

You're correct about the dependency.  I had changed it in the
<dependency> section but forgot about Manfred's shared refactoring
magic.  Good catch.  I'm checking in a fixed POM now.

Sean

On 4/12/06, Jeremy J. Grelle <[EMAIL PROTECTED]> wrote:
>
>
>
> Hello everyone.  I just started to try and do some testing of the
1.1.2
> release and noticed a possible problem when I cleared out my maven
repo so
> that I could do a clean build.  When building the core-impl package,
maven
> went and grabbed myfaces-shared-impl-2.0.1-SNAPSHOT.jar for
> the repackaging bit.  Shouldn't it be getting
myfaces-shared-impl-2.0.0.jar?
>
>
>
> Found the following bit in the pom.xml that is triggering this:
>
>
>
>              <plugin>
>
>         <groupId>org.codehaus.mojo</groupId>
>
>         <artifactId>dependency-maven-plugin</artifactId>
>
>         <executions>
>
>           <execution>
>
>             <id>unpack-shared-impl</id>
>
>             <phase>process-classes</phase>
>
>             <goals><goal>unpack</goal></goals>
>
>             <configuration>
>
>               <artifactItems>
>
>                 <artifactItem>
>
>                    <groupId>org.apache.myfaces.shared</groupId>
>
>
> <artifactId>myfaces-shared-impl</artifactId>
>
>                    <version>2.0.1-SNAPSHOT</version>
>
>                  </artifactItem>
>
>                </artifactItems>
>
>
> <outputDirectory>${project.build.directory}/classes</outputDirectory>
>
>             </configuration>
>
>           </execution>
>
>         </executions>
>
>       </plugin>
>
>
>
> Thanks,
>
> Jeremy
>
>
>
>

Reply via email to