[
http://issues.apache.org/jira/browse/TOMAHAWK-47?page=comments#action_12378497
]
Mike Kienenberger commented on TOMAHAWK-47:
-------------------------------------------
Sean,
My guess is that you've fixed the problem.
However, you haven't left any backward-compatibility with all of those facelets
users who've been using tree2 up to this point by using the fully-qualified
attribute name.
Have you considered temporarily having your getters also check for the
fully-qualified name, and issuing a log warning? At minimum, we at least need
to throw an error if a FQN has been specified.
Something like:
public boolean isShowNav()
{
if (_showNav != null) return _showNav.booleanValue();
// TODO: temporarily support fully-qualified tree2 attribute names.
ValueBinding vb = getValueBinding("org.apache.myfaces.tree2.SHOW_NAV");
if (vb != null)
{
log.warning("org.apache.myfaces.tree2.SHOW_NAV" is deprecated.
Please use showNav instead.");
Boolean v = vb != null ? (Boolean)vb.getValue(getFacesContext()) :
null;
return v == null || v.booleanValue();
}
ValueBinding vb = getValueBinding("showNav");
Boolean v = vb != null ? (Boolean)vb.getValue(getFacesContext()) : null;
return v == null || v.booleanValue();
}
> Tree2 is not compatible with facelets
> -------------------------------------
>
> Key: TOMAHAWK-47
> URL: http://issues.apache.org/jira/browse/TOMAHAWK-47
> Project: MyFaces Tomahawk
> Type: Bug
> Components: Tree2
> Versions: 1.1.1
> Environment: Facelets
> Reporter: Nicolas Belisle
> Assignee: sean schofield
> Fix For: 1.1.3-SNAPSHOT
> Attachments: tree2Patch.patch
>
> Hi,
> The Tree2 component should provide getter and setter for the properties:
> - showLines
> - showNav
> - clientSideToggle
> - showRootNode
> - preserveToggle
> Instread, HtmlTreeRenderer is now using the method getBoolean to get access
> to the above values (which are set by TreeTag).
> This strategy only works with JSP. These properties cannot be set in
> Facelets.
> A patch will follow shortly.
> Regards,
> Nicolas
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
