I originally had the attribute be "orientation" with values "horizontal" and "vertical", but I figured since there were only two values, it was better to make it boolean. But I can change it back. Yes, it only affects newspaperColumn tables. I was going to ask you to look it over, but you beat me to it. Any other problems/comments? I'll make a new jira and mark this one as fixed.
Thanks, Lance -----Original Message----- From: Mike Kienenberger (JIRA) [mailto:[EMAIL PROTECTED] Sent: Thursday, May 18, 2006 2:11 PM To: [EMAIL PROTECTED] Subject: [jira] Commented: (TOMAHAWK-440) Add orientation parameter to NewspaperTable [ http://issues.apache.org/jira/browse/TOMAHAWK-440?page=comments#action_12412 427 ] Mike Kienenberger commented on TOMAHAWK-440: -------------------------------------------- Does this only affect newspaperColumn tables? If so, we should rename it to be newspaperHorizontalOrientation. It might also be better to have the values be "horizontal" and "vertical" rather than a boolean, in which case we'd name the attribute newspaperOrientation. Sorry to be saying all of this stuff after the fact -- I hadn't had time to look at your original patch. > Add orientation parameter to NewspaperTable > ------------------------------------------- > > Key: TOMAHAWK-440 > URL: http://issues.apache.org/jira/browse/TOMAHAWK-440 > Project: MyFaces Tomahawk > Type: Improvement > Components: Extended Datatable > Versions: 1.1.3-SNAPSHOT > Reporter: Lance Frohman > Priority: Minor > Fix For: 1.1.3-SNAPSHOT > Attachments: HtmlDataTable.java.patch, HtmlDataTableTag.java.patch, > HtmlTableRenderer.java.patch, HtmlTableRendererBase.java.patch, > NewspaperTable.java.patch, extDataTable.xml.patch, > newspaperTable.jsp.patch, > tomahawk_newspaper_table_attributes.xml.patch > > This change just adds a boolean parameter "horizontalOrientation" to > the dataTable tag. The current version adds columns vertically. The > "horizontalOrientation" parameter tag can be "false" - the default, how it works currently - or "true" so that columns get added horizontally. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
