Done, I replaced TOMAHAWK-440 with TOMAHAWK-441. (I'm using up all the JIRA numbers).
-----Original Message----- From: Mike Kienenberger [mailto:[EMAIL PROTECTED] Sent: Thursday, May 18, 2006 4:43 PM To: MyFaces Discussion Cc: Mike Kienenberger (JIRA) Subject: Re: [jira] Commented: (TOMAHAWK-440) Add orientation parameter to NewspaperTable On 5/18/06, L Frohman <[EMAIL PROTECTED]> wrote: > quick question, I have the following line in HtmlTableRendererBase.java. > > boolean newspaperVerticalOrientation = > !"horizontal".equals(getNewspaperOrientation(component)); > > "horizontal" should be a constant somewhere (private static final > String), but it belongs in the newspaperTable code (tomahawk), and > HtmlTableRendererBase is in the shared code, it shouldn't reference > tomahawk. So where should I put the constant for "horizontal"? In shared-core, internally use your original idea -- boolean isVerticalOrientation() and have it always return true. Then override it in the Tomahawk class using the constants. At that point you can stick them in the NewspaperTable interface class. See getNewspaperColumns in shared-core:HtmlTableRendererBase as an example of this trick.
