Thank for your review Mario,

using findNestingForm may be good, but I don't know if it is used
elsewhere. Maybe other objects "rely" on the component returned to be
an UIForm? I went with a conservative approach. Moreover, the original
code itself didn't make use of that utility method.

Anyway, if you think that using that findNestingForm is a better way,
I have no problem adapting the code. Just let me know, I created an
issue on JIRA and I'm about to upload the patch there.

Ciao
Cosma


2006/7/5, Mario Ivankovits <[EMAIL PROTECTED]>:
Hi Cosma!
> Okey, done.
> Here is the patched patch :)
Ok, fine, but, wouldnt it be best to change the
org.apache.myfaces.shared.util._ComponentUtils.findNestingForm to work
with trinidad too and use this in HtmlJSCookMenuRenderer.java? Just an idea.

Everything else looks fine to me.

Ciao,
Mario


Reply via email to