[
https://issues.apache.org/jira/browse/TRINIDAD-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520648
]
Jeanne Waldman commented on TRINIDAD-635:
-----------------------------------------
Also, make sure to doc in skin-selectors the 'included' styles.
For example, this is in the base-desktop.xss:
<style selector="af|panelBox::light af|panelBox::body">
<includeStyle name="AFBoxBackground"/>
</style>
<style selector="af|panelBox::medium af|panelBox::body">
<includeStyle name="AFPanelBoxMediumBackground"/>
</style>
<style selector="af|panelBox::dark af|panelBox::body">
<includeStyle name="AFPanelBoxDarkBackground"/>
</style>
So somewhere in skin-selectors.xml it should be mentioned that
af|panelBox::dark af|panelBox::body includes AFPanelBoxDarkBackground, etc.
I don't see it now, and aliases are really important to mention.
> panelBox skinning keys in purple skin demo are obsolete
> -------------------------------------------------------
>
> Key: TRINIDAD-635
> URL: https://issues.apache.org/jira/browse/TRINIDAD-635
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Reporter: Jeanne Waldman
> Priority: Minor
>
> The purple skin used to demo the panelBox correctly. The panelBox's skin
> selectors have changed and the demo was never updated to reflect the changes.
> This is confusing to someone trying to figure out how to skin the panelBox.
> Whenever skin selectors are changed, we need to update the demos as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
