On 10/27/07, Manfred Geiler <[EMAIL PROTECTED]> wrote: > Proposal for a MyFaces maven master pom refactoring. > > The current maven master pom for MyFaces has some flaws: > > 1. Not used by all MyFaces (sub)projects. > Currently Tobago has no parent pom and Trinidad uses > org.apache:apache:4 directly.
This is not a flaw in the master pom, but rather in those sub-projects. :) > 2. Located in the "maven" folder (i.e. > org.apache.myfaces.maven:maven-project artifact). > The MyFaces maven project is currently a mixture of maven related > stuff. Having the master(!) located within this sub project is a bad > idea. Where it lives on the filesystem, and where it sits in the pom hierarchy are separate matters. It can stay in a "maven" directory, but inherit directly from the ASF master pom (which it does). I think the easiest thing here is to get rid of the 'maven-project' pom altogether. Each thing in the "maven" directory (rename it if you want...) is a separate item either extending from the myfaces-master pom or (in the case of the myfaces-master pom itself) from the ASF parent pom. They do not (collectively) need a parent pom listing them as modules. I don't care if you want to make the master pom separate with its own trunk/branches/tags, but it doesn't seem necessary. > The master pom should be it's own project, depending only on the > org.apache:apache master pom and ALL other MyFaces projects should > derive from it. +1 > 3. Version numbering. > I propose "8" as the first number after the pom move/refactoring. +1 > 4. There is stuff in the myfaces master that is NOT common (or even > unused?) to all myfaces projects and should not be there IMHO. These > are: > 4a. Wagon extension. Who needs this? > <extension> > <groupId>org.apache.maven.wagon</groupId> > <artifactId>wagon-ssh-external</artifactId> > <version>1.0-alpha-5</version> > </extension> What does the commit log say when it was added? Someone must have needed it... > 4b. Myfaces build tools as extension. Who needs this? > <extension> > <groupId>org.apache.myfaces.maven</groupId> > <artifactId>build-tools</artifactId> > <version>1.0.7-SNAPSHOT</version> > </extension> It probably has the checkstyle rules in it... and yes, it would be nice to agree on a set of rules across the project. -- Wendy
