On 10/27/07, Wendy Smoak <[EMAIL PROTECTED]> wrote:
> On 10/27/07, Manfred Geiler <[EMAIL PROTECTED]> wrote:
> > Proposal for a MyFaces maven master pom refactoring.
> >
> > The current maven master pom for MyFaces has some flaws:
> >
> > 1. Not used by all MyFaces (sub)projects.
> > Currently Tobago has no parent pom and Trinidad uses
> > org.apache:apache:4 directly.
>
> This is not a flaw in the master pom, but rather in those sub-projects. :)
Sure :-)
But the other flaws seem to have scared people from using it as a
master, so it is also a flaw of the myfaces master pom itself. ;-)
> > 2. Located in the "maven" folder (i.e.
> > org.apache.myfaces.maven:maven-project artifact).
> > The MyFaces maven project is currently a mixture of maven related
> > stuff. Having the master(!) located within this sub project is a bad
> > idea.
>
> Where it lives on the filesystem, and where it sits in the pom
> hierarchy are separate matters. It can stay in a "maven" directory,
> but inherit directly from the ASF master pom (which it does).
Yes, sure. But the fact that it "hides" in the maven project confuses
many people. It should be located in a more prominent location.
> I think
> the easiest thing here is to get rid of the 'maven-project' pom
> altogether.
Yes. Agreed. Only problem I see: as long as the myfaces master depends
on some other myfaces stuff (checkstyle) there must be someone who
tells maven the build order. This is what the maven-project pom
currently does.
See below for more on that issue.
> Each thing in the "maven" directory (rename it if you want...) is a
> separate item either extending from the myfaces-master pom or (in the
> case of the myfaces-master pom itself) from the ASF parent pom. They
> do not (collectively) need a parent pom listing them as modules.
>
> I don't care if you want to make the master pom separate with its own
> trunk/branches/tags, but it doesn't seem necessary.
Yes, I would really like to see a "myfaces-master-pom" in our myfaces svn root.
>
> > 4. There is stuff in the myfaces master that is NOT common (or even
> > unused?) to all myfaces projects and should not be there IMHO. These
> > are:
> > 4a. Wagon extension. Who needs this?
> > <extension>
> > <groupId>org.apache.maven.wagon</groupId>
> > <artifactId>wagon-ssh-external</artifactId>
> > <version>1.0-alpha-5</version>
> > </extension>
>
> What does the commit log say when it was added? Someone must have needed
> it...
rev 412444 07.06.2006 18:13:29 grantsmith
"MYFACES-1325: Mods to pom.mxl for correct continuum reporting"
Well...
> > 4b. Myfaces build tools as extension. Who needs this?
> > <extension>
> > <groupId>org.apache.myfaces.maven</groupId>
> > <artifactId>build-tools</artifactId>
> > <version>1.0.7-SNAPSHOT</version>
> > </extension>
>
> It probably has the checkstyle rules in it... and yes, it would be
> nice to agree on a set of rules across the project.
The current config is:
<configuration>
<configLocation>http://svn.apache.org/repos/asf/myfaces/maven/trunk/build-tools/src/main/resources/config/myfaces-checks.xml</configLocation>
<headerLocation>http://svn.apache.org/repos/asf/myfaces/maven/trunk/build-tools/src/main/resources/config/myfaces-header.txt</headerLocation>
</configuration>
So, the master does not really depend on the build-tools artifact - at
least not the maven way. It catches the latest stuff from svn
directly. Now, what about having those two files directly in the new
master root:
/repos/asf/myfaces/myfaces-master-pom/pom.xml
/repos/asf/myfaces/myfaces-master-pom/myfaces-checks.xml
/repos/asf/myfaces/myfaces-master-pom/myfaces-header.txt
Or is there a better way than to depend on an online (http: !) ressource?
--Manfred
