ok, go ahead! -M
On Jan 20, 2008 6:54 AM, simon <[EMAIL PROTECTED]> wrote: > Hi, > > I've noticed some peculiarities with the way that license and notice > files are handled in the maven-build-tools/maven2-plugins project and > its child modules. > > (1) > For most child modules there are currently two copies of LICENSE and > NOTICE checked in to svn. One is in the base directory of the module and > the other is under src/main/resources/META-INF. > > I think it's not a good idea to have two effectively identical files > checked in at multiple places. Each module *does* need its own copy of > each, as each can potentially have different NOTICE info, and each can > potentially be checked out separately. However within each module there > should only be one copy of these files, at the module root directory. > > The myfaces-wagon-plugin module does not actually have these files in > the root directory, just in the resources dir. > > (2) > The parent pom (maven2-plugins) currently uses the > apache-jar-resources-bundle part of the maven-remote-resources-plugin. > > AFAIK, the presence of checked-in NOTICE and LICENSE files is actually > preventing this plugin from having any effect - in anything but the > myfaces-wagon-plugin project. > > In the wagon project, however, because there is no file at the root > level it is being triggered - to *generate* a NOTICE file which is then > included in the jar. This behaviour of generating a NOTICE file has been > extensively discussed recently on the commons-dev list, and on the > legal-discuss list. > > I'll let you read the archives for those to form your own opinion of > whether this plugin is in compliance with ASF policy. > > However *my* understanding is that it is not, ie that the > apache-jar-resources-bundle feature should never be used. > > > > > > So what I would suggest is: > (a) remove the apache-jar-resources-bundle section from the parent > myfaces-build-tools/maven2-plugins pom > (b) delete the notice and license files from the src/main/resources > directory of every submodule (redundant) > (c) add notice/license files to the root directory of the > myfaces-wagon-plugin (missing) > > FYI, the apache-jar-resources-bundle feature was first added in r512317, > on 2007-02-27. > > Regards, > Simon > > > -- Matthias Wessendorf further stuff: blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf mail: matzew-at-apache-dot-org
