Ok, tried - but don't have commit permissions to this project it seems:
svn: Commit failed (details follow):
svn: MKACTIVITY of '/repos/asf/!
svn/act/eefd0a04-73aa-4150-81d5-8d85f511742e': 403 Forbidden
(http://svn.apache.org)
svn: Your commit message was left in a temporary file:
Odd, it looks more like a global problem, but I committed something just
10 minutes ago.
Could you please apply the attached patch? The commit message is:
* remove use of apache-jar-resource-bundle to generate NOTICE files
* fix issue-tracking url
* add version numbers for some plugins
* upgrade version numbers for some plugins
* remove redundant groupId=org.apache.maven.plugins
* other minor tidyups
Regards, Simon
On Sun, 2008-01-20 at 08:54 -0800, Matthias Wessendorf wrote:
> ok,
> go ahead!
>
> -M
>
> On Jan 20, 2008 6:54 AM, simon <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
> > I've noticed some peculiarities with the way that license and notice
> > files are handled in the maven-build-tools/maven2-plugins project and
> > its child modules.
> >
> > (1)
> > For most child modules there are currently two copies of LICENSE and
> > NOTICE checked in to svn. One is in the base directory of the module and
> > the other is under src/main/resources/META-INF.
> >
> > I think it's not a good idea to have two effectively identical files
> > checked in at multiple places. Each module *does* need its own copy of
> > each, as each can potentially have different NOTICE info, and each can
> > potentially be checked out separately. However within each module there
> > should only be one copy of these files, at the module root directory.
> >
> > The myfaces-wagon-plugin module does not actually have these files in
> > the root directory, just in the resources dir.
> >
> > (2)
> > The parent pom (maven2-plugins) currently uses the
> > apache-jar-resources-bundle part of the maven-remote-resources-plugin.
> >
> > AFAIK, the presence of checked-in NOTICE and LICENSE files is actually
> > preventing this plugin from having any effect - in anything but the
> > myfaces-wagon-plugin project.
> >
> > In the wagon project, however, because there is no file at the root
> > level it is being triggered - to *generate* a NOTICE file which is then
> > included in the jar. This behaviour of generating a NOTICE file has been
> > extensively discussed recently on the commons-dev list, and on the
> > legal-discuss list.
> >
> > I'll let you read the archives for those to form your own opinion of
> > whether this plugin is in compliance with ASF policy.
> >
> > However *my* understanding is that it is not, ie that the
> > apache-jar-resources-bundle feature should never be used.
> >
> >
> >
> >
> >
> > So what I would suggest is:
> > (a) remove the apache-jar-resources-bundle section from the parent
> > myfaces-build-tools/maven2-plugins pom
> > (b) delete the notice and license files from the src/main/resources
> > directory of every submodule (redundant)
> > (c) add notice/license files to the root directory of the
> > myfaces-wagon-plugin (missing)
> >
> > FYI, the apache-jar-resources-bundle feature was first added in r512317,
> > on 2007-02-27.
> >
> > Regards,
> > Simon
> >
> >
> >
>
>
>
Index: pom.xml
===================================================================
--- pom.xml (revision 613635)
+++ pom.xml (working copy)
@@ -31,7 +31,7 @@
<issueManagement>
<system>jira</system>
- <url>http://issues.apache.org/jira/browse/TRINIDAD</url>
+ <url>http://issues.apache.org/jira/browse/MYFACES</url>
</issueManagement>
<ciManagement>
@@ -51,32 +51,11 @@
<inceptionYear>2001</inceptionYear>
<build>
- <plugins>
- <plugin>
- <artifactId>maven-remote-resources-plugin</artifactId>
- <version>1.0-alpha-6</version>
- <executions>
- <execution>
- <goals>
- <goal>process</goal>
- </goals>
- <configuration>
- <resourceBundles>
- <resourceBundle>org.apache:apache-jar-resource-bundle:1.1</resourceBundle>
- </resourceBundles>
- <properties>
- <addLicense>true</addLicense>
- </properties>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
<pluginManagement>
<plugins>
<plugin>
<artifactId>maven-jar-plugin</artifactId>
- <version>2.1</version>
+ <version>2.2</version>
<configuration>
<archive>
<manifest>
@@ -92,7 +71,6 @@
<reporting>
<plugins>
<plugin>
- <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-project-info-reports-plugin</artifactId>
<version>2.0.1</version>
</plugin>
@@ -114,7 +92,7 @@
<scm>
<connection>scm:svn:http://svn.apache.org/repos/asf/myfaces/myfaces-build-tools/trunk/maven2-plugins/</connection>
- <developerConnection>scm:svn:https://svn.apache.org/repos/asf/myfaces/myfaces-build-tools/trunk/maven2-plugins//</developerConnection>
+ <developerConnection>scm:svn:https://svn.apache.org/repos/asf/myfaces/myfaces-build-tools/trunk/maven2-plugins/</developerConnection>
<url>http://svn.apache.org/viewvc/myfaces/myfaces-build-tools/trunk/maven2-plugins/</url>
</scm>
@@ -138,7 +116,7 @@
</snapshotRepository>
<site>
<id>apache-site</id>
- <url>scpexe://minotaur.apache.org/www/myfaces.apache.org/trinidad/plugins/</url>
+ <url>scpexe://people.apache.org/www/myfaces.apache.org/myfaces/plugins/</url>
</site>
</distributionManagement>
@@ -152,8 +130,8 @@
<build>
<plugins>
<plugin>
- <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
+ <version>1.0-alpha-4</version>
<executions>
<execution>
<id>sign-artifacts</id>
@@ -166,7 +144,7 @@
</plugin>
<plugin>
<artifactId>maven-javadoc-plugin</artifactId>
- <version>2.2</version>
+ <version>2.3</version>
<executions>
<execution>
<id>attach-javadocs</id>
@@ -177,8 +155,8 @@
</executions>
</plugin>
<plugin>
- <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-scm-plugin</artifactId>
+ <version>1.0</version>
<executions>
<execution>
<phase>validate</phase>
