Andrew Robinson wrote:
Could we move this discussion away from a debate?
Could MyFaces Committers or PMC members _only_ please share their
thoughts on this to keep the discussion to the stake holders only?
Please share other solutions as you have them.
Here some view points to discuss:
1) remove the restriction of trinidad-impl being non-API and enforce
that code in this package be backward-compatible
I think the current code it to immature to allow this
2) somehow move some of the burden of parts of renderers out of
trinidad-impl and into trinidad-api
+1, We should look at this on a library by library basis and scrutinize
the code
3) introduce some configurable way to override default behavior for
rendering certain areas of components.
+1 +1, that's been my point all along
4) removing some final modifiers after discussion and make extending
Trinidad renderers accepted, aka not tabu
-0 for the reasons I stated. Trinidad is OpenSource, we've already
given people enough rope to hang themselves with, no need to tie the
noose for them as well. I would support this on an as-needed basis if
that's what you mean by "after discussion" but these should be
exceptions and SHOULD be hard to pass though in order to get people to
think before they extend Impl classes. Not even in Regular Faces are
the "renderer's" public which is why I think this discussion largely
academic.
5) promoting private members to protected or public after discussion
and make extending Trinidad renderers accepted, aka not tabu
See comment to number 4
Christi, could you please share more of your needs and give further
legitimate reasons why this is needed?
Yeah, I mean we have in the past made things protected and non-final
when it was needed for extensions, but it's always been by people who
are not afraid to make commits. I would certainly be open to loosening
API's for specific usecases, I was meerly against changing them
carte-blanche. The *right* answer IMO though is #2 and #3.
Scott
If you are not a member of MyFaces, Committer or PMC member please
refrain from further reply to this thread as your feedback has already
been noted.
Thank you,
Andrew
On Wed, Apr 9, 2008 at 6:23 PM, Cristi Toth <[EMAIL PROTECTED]> wrote:
Hi guys,
A lot of Trinidad renderers have some "override useful" methods as private
or protected final.
This makes customizing renderers a nasty job.
- first these methods obviously can't be overriden
- then when trying to override some public/protected methods,
it's hard because they use other private methods that you can't use in
your overriden method
I assume this come from the fact that Trinidad wasn't open-source in its
origins... or?
Do we still have reasons to keep it this way?
IMO we could make those protected final "override useful" methods to
protected
and the private methods used in those methods, make them protected final.
What's you opinion on this?
Regards,
--
Cristi Toth
-------------
Codebeat
www.codebeat.ro
