Hi, Jihoon Kim schrieb: > Hi! > > I was hoping if someone can take a look at a recent contribution that > I have made to the sandbox and see if it is something that I should > spend more of my free time with=> > https://issues.apache.org/jira/browse/TOMAHAWK-1250 > > I have detailed much about the contribution within the Jira, but in a > nutshell it is to give users capability in creating Adobe Flex > components as MyFaces JSF components. So users would create the > components as normal JSF components and the contribution will create > the necessary SWF files and etcetera and link the values of the > components back to the managed beans using JSON+Javascript and > etcetera. > > One caveat is that users will need to download the free Adobe Flex SDK > to C:\Program Files\flexSDK or /usr/local/bin/flexSDK [haven't tested > on linux yet]. > > I thought it would be an interesting set of components and if it is > something that seems to have some potential I will fine tune the code > more and give additional capabilities within the components. I have > tried to keep to some of the standards within the myfaces project by > including tons of .xml files for tld attributes and have attached a > patch for set of files and a zip for others [since there exists > multiple directories and files within them]. >
Thanks very much for offering this code to the myfaces project. I had a quick look yesterday, and the code seems to be very nicely written. I'm sure it will be useful to many people. Before this becomes part of a MyFaces project, however, there are a few questions to answer: a) Abobe flex is a proprietary product. Therefore, is a wrapper for it suitable as an ASF project? b) Does the code comply with the ASF legal rules regarding licensing? c) Is there a large enough development community to keep this code maintained? d) What project should the code be included in? == (a) The ASF always uses the Apache License 2.0 (AL2.0). This is meant to be a "business friendly" license, in that code under this license can be included in proprietory products. However in general the ASF does try to promote open source over proprietory products. As far as I know, Flex is completely proprietory to Adobe, and this wrapper code has no other purpose than allowing this proprietory code to be used. Therefore I'm not sure that it is in the spirit of ASF to host it here. == (b) The ASF has a strict rule that no code hosted in the apache svn repository can contain import some.gpl.api I'm reasonably sure that the same rule bans "import" of packages whose license is not compatible with AL2.0. I can't see any such calls in the provided code; it seems that the code just outputs HTML statements that happen to reference Flex plugins (which would probably be ok). Can you confirm that nowhere in the java code are any "import" statements of adobe java libs? == (c) The ASF differs from sourceforge, etc., in that it is serious about long-term maintenance of the projects it hosts. This means ensuring that there before any code becomes an official ASF project it has a group of people willing to maintain it. Are there other people who are willing to keep this code valid, and respond to bugreports etc? == (d) The patch is written so that the code is part of the Tomahawk project. However I don't think this would be the best place for it. The people who use tomahawk will not usually want this code, and the people who want this code will often not want the rest of tomahawk. And in addition, I personally would like to see tomahawk put into "maintenance only" mode, with the best bits being moved instead into the new "myfaces commons" modules. == Please don't take this as a rejection; this is just my initial thoughts. Hopefully other people will comment as well. As most of the developers on this list are very busy it may take a week or so for people to get around to evaluating such a large chunk of code. Note that even if the consensus is that this code is not appropriate for MyFaces or Apache, it still looks very useful and we would all wish you success with the project no matter where it gets hosted. Regards, Simon
