Hi

On Sat, May 31, 2008 at 2:48 PM, simon <[EMAIL PROTECTED]> wrote:

> Hi,
>
> Here are some things I noticed when reviewing the tlddocs for
> core11-based-on-myfaces-builder.
>
> Tag f:selectItems now has a "rendered" attribute, which it should not.


This problem is caused because the plugin enforces inheritance of
properties. The solution is do something like this:

 * @JSFComponent
 *   name = "f:selectItems"
 *   bodyContent = "empty"
 *   tagClass = "org.apache.myfaces.taglib.core.SelectItemsTag"
 *   desc = "UISelectItems"
 * @JSFJspProperty name = "rendered" returnType = "boolean" tagExcluded =
"true"
 */
public class UISelectItems extends UIComponentBase

When the hierarchy is merged, tagExcluded = "true" takes precedence, so this
property is not mentioned on tld anymore.


> Tag f:view has id, rendered and binding which it should not.
>

The same applies:

 * @JSFJspProperty name = "rendered" returnType = "boolean" tagExcluded =
"true"
 * @JSFJspProperty name = "binding" returnType = "java.lang.String"
tagExcluded = "true"
 * @JSFJspProperty name = "id" returnType = "java.lang.String" tagExcluded =
"true"


> Tag h:inputTextarea previously had "datafld", "datasrc", "dataformatas".
> These are no longer there, but they do not exist in the sun docs either.
>

I ignore if this attributes will ever work (there are defined on tomahawk
but the docs says "reserved for future usage" or no description). The best
is remove it from tld (like is suggested in the old
org.apache.myfaces.shared_impl.taglib.html.HtmlInputTextareaTagBase).


> Tags h:message/h:messages previously had "dir", "lang" attributes, and a
> set of "onmouse*", "onkey*" attributes. These are no longer there, but
> they do not exist in the sun docs either.
>

The jsf 1.1 spec doc does not define explicitly the attributes, but I
suppose that if there are new attributes to be added on original components,
this should be done on tomahawk (like is happening right now).


>
> I'll try to look into these myself if I can find time. But if anyone
> wants to deal with them first, please do!
>
> Regards,
> Simon
>
>
I'll commit the solution to the problems detected

regards

Leonardo Uribe

Reply via email to