On Mon, 2008-06-02 at 21:57 -0500, Leonardo Uribe wrote:
> Hi
>
> I have committed the changes.
Thanks!
>
> Reading the email again, I forget to mention my opinion about change
> "tagExcluded" setting to "ignore".
>
> In the plugin there are several levels of "ignore" (only two used in
> practice):
>
> tagExcluded = true: generate the property with state saving and
> restoring code on the .tld if applies, but do not generate on the Tag
> class and do not include on the tld. It is also used to exclude
> from .tld already defined properties.
>
> inheritedTag = true: assume that the code on Tag is inside the
> hierarchy, and include on the tld.
>
> transient(never used)=generate property but do not included on
> saveState and restoreState methods.
>
> I feel that "tagExcluded" or a similar name is more intuitive than
> "ignore", according to the intention of the property.
Ah..but I think the isRendered method should be overridden too.
You said in an earlier email:
<quote>
override isRendered is bad, because this method is used on processXXX
and encodeXXX methods
</quote>
I presume you meant that overriding it to throw an exception would not
work. I agree, but would override it like this:
public boolean isRendered() {
return true;
}
After all, if nobody is allowed to set the rendered state, then that is
what will happen anyway, right?
And this makes it clear that there is no point in trying to save the
rendered flag in saveState/restoreState etc. But it's not really
"transient" state either; it's state that never should have existed.
Which is why I think "ignore" would be a better name. But that's not so
important.
Sorry, but I didn't follow your description of "inheritedTag". What do
you mean by "inside the hierarchy"?
Regards,
Simon
