[ 
https://issues.apache.org/jira/browse/TOMAHAWK-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602167#action_12602167
 ] 

Leonardo Uribe commented on TOMAHAWK-1023:
------------------------------------------


Checking tomahawk, it does not override javax.faces.Hidden renderer, so this 
test is against jsf ri renderer.

Tomahawk just add ForceAware feature to HtmlInputHidden, so there is no need to 
override the renderer.

Anyway, still there is the problem on jsf ri test. One solution is just skip 
this test, because we can't do anything from myfaces side, or copy it from 
myfaces impl project and reference the tomahawk inputHidden to myfaces renderer.

The more easy is solution 2, so I'll commit it if no objections.


> HtmlInputHidden fails unit test when using RI
> ---------------------------------------------
>
>                 Key: TOMAHAWK-1023
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1023
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6, 1.1.7-SNAPSHOT
>            Reporter: Paul Spencer
>             Fix For: 1.1.7-SNAPSHOT
>
>
> -------------------------------------------------------------------------------
> Test set: org.apache.myfaces.component.html.ext.HtmlInputHiddenTest
> Below are output from the test failures. The test are run using the following 
> command:
>    cd tomahawk/core
>    mvn test -Djsf=ri 
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec <<< 
> FAILURE!
> testDefaultRenderer(org.apache.myfaces.component.html.ext.HtmlInputHiddenTest)
>   Time elapsed: 0.016 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: ID is not null
>       at junit.framework.Assert.fail(Assert.java:47)
>       at junit.framework.Assert.assertTrue(Assert.java:20)
>       at junit.framework.Assert.assertNotNull(Assert.java:220)
>       at 
> org.apache.myfaces.test.AbstractTomahawkViewControllerTestCase.assertIdExists(AbstractTomahawkViewControllerTestCase.java:88)
>       at 
> org.apache.myfaces.component.html.ext.HtmlInputHiddenTest.testDefaultRenderer(HtmlInputHiddenTest.java:64)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to